Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resume_unwind instead of panic!() for nicer errors #176

Merged
merged 1 commit into from Sep 12, 2019

Conversation

@phansch
Copy link
Contributor

commented Apr 16, 2019

Merged in rustc: rust-lang/rust#59990

@phansch

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

Is there any policy regarding licensing and/or including other people's commits?

cc @bjorn3 in case you want to know about this.

@phansch phansch force-pushed the phansch:resume_unwind branch from 3b1ca5f to c780627 Apr 16, 2019
@bjorn3

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

Is there any policy regarding licensing and/or including other people's commits?

Rust and compiletest-rs both use Apache 2.0 / MIT, so there are no license problems. I don't know about the policy, but I am fine with this.

cc @bjorn3 in case you want to know about this.

Thanks :)

@phansch

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2019

@Munksgaard I believe also this should be ready to merge =)

@Munksgaard

This comment has been minimized.

Copy link
Collaborator

commented Sep 12, 2019

Great 👍

@Munksgaard Munksgaard merged commit 7d78980 into laumann:master Sep 12, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@phansch phansch deleted the phansch:resume_unwind branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.