Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for upstream's 'edition' flag #180

Merged
merged 3 commits into from Sep 11, 2019

Conversation

@phansch
Copy link
Contributor

commented May 20, 2019

Needs to be merged after #181

@Munksgaard

This comment has been minimized.

Copy link
Collaborator

commented Aug 21, 2019

Now that #183 has superseeded #181, could you perhaps rebase this PR so we can merge it?

@phansch phansch force-pushed the phansch:add_edition_support branch from feb6df2 to 5ad6705 Aug 21, 2019
@phansch

This comment has been minimized.

Copy link
Contributor Author

commented Aug 21, 2019

@Munksgaard this needs #171 first, to make use of the nightly only testsuite for async.

@Munksgaard

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

I've gone ahead and merged #171, so with a rebase perhaps we can merge this PR as well?

@phansch

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

@Munksgaard yup, I will rebase later today, thanks for the reminder!

@Munksgaard

This comment has been minimized.

Copy link
Collaborator

commented Sep 10, 2019

@Munksgaard yup, I will rebase later today, thanks for the reminder!

No worries, I only just merged your other PR 😁

phansch added 3 commits May 20, 2019
Once `async` is stable, this could actually be in the non-nightly test
suite.
@phansch phansch force-pushed the phansch:add_edition_support branch from 8583d62 to 41ec893 Sep 10, 2019
@phansch

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

Rebased and added 41ec893 to move the added test to the nightly test suite.

@Munksgaard Munksgaard merged commit 0d7c167 into laumann:master Sep 11, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Munksgaard

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2019

Thanks!

@phansch phansch deleted the phansch:add_edition_support branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.