-
Notifications
You must be signed in to change notification settings - Fork 12
Provide meta file options for environmentAliases and environmentTypeNames
#98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 89.03% 89.06% +0.03%
==========================================
Files 21 21
Lines 1724 1738 +14
Branches 407 414 +7
==========================================
+ Hits 1535 1548 +13
- Misses 189 190 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks for implementing this so quickly!
I agree that naming this new variable is tough since we have many meanings of 'environment' in app-config. Other ideas that come to mind are something like environmentInputNames or environmentSourceNames since it describes the names of variables used for environment input/source.
Closes #20.
I'm not entirely happy with the name
environmentSourceNames, butenvironmentVariableNameis already used for 'APP_CONFIG'.