feat: add all available attributes to a span #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
|
Unfortunately, I don't have a way to test macOS. @kinyoklion, do you have a way to troubleshoot the failed test? |
|
@beeme1mr It is an unrelated flake, so no concerns. We will be looking at it. |
kinyoklion
approved these changes
Oct 6, 2025
kinyoklion
pushed a commit
that referenced
this pull request
Oct 7, 2025
🤖 I have created a release *beep* *boop* --- ## [1.4.0](LaunchDarkly.ServerSdk.Telemetry-v1.3.0...LaunchDarkly.ServerSdk.Telemetry-v1.4.0) (2025-10-06) ### Features * add all available attributes to a span ([#167](#167)) ([7350aac](7350aac)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Bumps `LaunchDarkly.ServerSdk.Telemetry` to 1.4.0 and documents a feature adding all available attributes to spans. > > - **Telemetry 1.4.0**: > - CHANGELOG: feature to add all available attributes to a span. > - Version bumps: `pkgs/telemetry/src/LaunchDarkly.ServerSdk.Telemetry.csproj` and `.release-please-manifest.json`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4dbb74c. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
N/A: I can create one if necessary
Describe the solution you've provided
This PR adds the ability to capture all available attributes when in "span mode". It will only add the additional attributes when
IncludeAllAttributesInSpanistrue; otherwise, the existing behavior is retained.This change is useful because it's easier to work with spans than span events in some observability tools. With this change, spans can have the same attributes as span events.
Describe alternatives you've considered
We could leave it as is but it would make spans less useful to consumers.
Additional context
I talked to @kinyoklion about this on Slack about this change prior to opening the PR.