Skip to content

Dispoing JsonDocument #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Dispoing JsonDocument #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/LaunchDarkly.JsonStream/JsonStreamConverterSystemTextJson.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,11 @@ public override T Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerial
// that a JReader can read from. That's less efficient than reading directly from the original
// reader, due to 1. preallocating the value struct(s) and 2. the overhead of JReader calling the
// delegate, but it's still better than actually parsing the JSON twice.
var jsonDocument = JsonDocument.ParseValue(ref reader);
var readerWrapper = JReader.FromAdapter(ReaderAdapters.FromJsonElement(jsonDocument.RootElement));
return (T)_jsonStreamConverter.ReadJson(ref readerWrapper);
using(JsonDocument jsonDocument = JsonDocument.ParseValue(ref reader))
{
var readerWrapper = JReader.FromAdapter(ReaderAdapters.FromJsonElement(jsonDocument.RootElement));
return (T)_jsonStreamConverter.ReadJson(ref readerWrapper);
}
}

public override void Write(Utf8JsonWriter writer, T value, JsonSerializerOptions options)
Expand Down