This repository was archived by the owner on May 30, 2024. It is now read-only.
Even more v2 things. #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| List<FeatureRequestEvent> prereqEvents = new ArrayList<>(); | ||
| JsonElement value = evaluate(user, featureStore, prereqEvents); | ||
| return new EvalResult(value, prereqEvents); | ||
| if (isOn()) { |
Contributor
Author
There was a problem hiding this comment.
I moved all flag eval logic into the FeatureFlag class. This enables us to call flag.evaluate() in the client's allFLags() method without additional logic around on/off behavior. Also, from an OO perspective it makes more sense: the object contains the data + the behavior.
Contributor
|
LGTM, but would like to know what that one change was about... |
| sendFlagRequestEvent(featureKey, user, defaultValue, defaultValue, null); | ||
| return defaultValue; | ||
| } | ||
| if (featureFlag.isOn()) { |
Contributor
Author
There was a problem hiding this comment.
@jkodumal this logic was moved into the FeatureFlag.evaluate method.
Contributor
|
👍 |
eli-darkly
added a commit
that referenced
this pull request
May 10, 2018
summary events (3): retry event posting once on exception or 5xx error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.