Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
92 commits
Select commit Hold shift + click to select a range
fa41287
add reconnect logic to stream
brooswit May 18, 2018
c59b0aa
Merge branch 'master' of github.com:launchdarkly/js-client-private in…
brooswit Jun 4, 2018
3e9a058
add config option streamReconnectDelay
brooswit Jun 4, 2018
9c44393
Merge branch 'master' of github.com:launchdarkly/js-client-private in…
brooswit Jun 11, 2018
4698a0f
Merge branch 'master' of github.com:launchdarkly/js-client-private in…
brooswit Jul 19, 2018
10e017c
update logic, add tests, add eventsource mock
brooswit Jul 19, 2018
2b458ae
add logic to prevent mocking events in invalid states
brooswit Jul 19, 2018
b9d4196
fix lint errors
brooswit Jul 19, 2018
e128f46
fix errors, fix tests, address pr comments
brooswit Jul 24, 2018
88727f8
retry event posts once
eli-darkly Aug 10, 2018
c7e40cf
linter
eli-darkly Aug 10, 2018
dc8fc3c
don't use jest-each, it causes strange problems in CI tests
eli-darkly Aug 10, 2018
c22d722
try to fix jest problem
eli-darkly Aug 10, 2018
5692c00
Revert "try to fix jest problem"
eli-darkly Aug 10, 2018
3f4ea95
document promise polyfill and make all polyfill sections consistent
apucacao Aug 13, 2018
d407bb9
fix typo
apucacao Aug 14, 2018
c9339ed
try to fix jdom error by setting jest url property
eli-darkly Aug 14, 2018
96a171e
bump jest version
eli-darkly Aug 14, 2018
8b23214
require earlier version of jsdom to avoid problem with mocking localS…
eli-darkly Aug 14, 2018
779bcc4
undo jest version change
eli-darkly Aug 14, 2018
4ebdb51
Merge pull request #90 from launchdarkly/eb/ch22174/jest-errors
eli-darkly Aug 14, 2018
3a90745
Merge branch 'master' into eb/ch15679/retry-events
eli-darkly Aug 14, 2018
bf35d1b
change identify() result back to a key-value map like it used to be
eli-darkly Aug 14, 2018
29c3df3
linter
eli-darkly Aug 14, 2018
22491fd
Merge pull request #91 from launchdarkly/eb/ch22186/identify-result
eli-darkly Aug 15, 2018
af2103c
Merge branch 'master' into ag/ch22054/readme-polyfills
eli-darkly Aug 15, 2018
b7a389f
Merge pull request #89 from launchdarkly/ag/ch22054/readme-polyfills
eli-darkly Aug 15, 2018
1cb4b79
Merge branch 'master' of github.com:launchdarkly/js-client
eli-darkly Aug 15, 2018
9182527
support extended bootstrap data format
eli-darkly Aug 16, 2018
e762629
linter
eli-darkly Aug 16, 2018
f2b20b2
add warning for bootstrap not having metadata
eli-darkly Aug 17, 2018
4a188b1
linter
eli-darkly Aug 17, 2018
aa78b6e
Merge pull request #92 from launchdarkly/eb/ch21387/bootstrap-metadata
eli-darkly Aug 22, 2018
b113ade
changes based on code review
brooswit Aug 22, 2018
2d07c91
Merge pull request #88 from launchdarkly/eb/ch15679/retry-events
eli-darkly Aug 23, 2018
b0dfc1d
add check for $valid property
eli-darkly Aug 24, 2018
0ccde84
linter
eli-darkly Aug 24, 2018
70a00c7
[ch22449] Make sure the TypeScript typings are included in our publis…
apucacao Aug 24, 2018
f4d5ff9
Merge pull request #93 from launchdarkly/eb/valid-flag
eli-darkly Aug 24, 2018
ecf7d0b
Merge branch 'all-flags-state'
eli-darkly Aug 25, 2018
5b0724a
Merge branch 'master' of github.com:launchdarkly/js-client
eli-darkly Aug 27, 2018
672bd50
change test reconnect delay to 0.1
brooswit Aug 28, 2018
c2ae296
add TypeScript syntax check
eli-darkly Aug 29, 2018
7e366af
Merge branch 'master' into jw/ch12336
eli-darkly Aug 29, 2018
2f6d921
Merge pull request #70 from launchdarkly/jw/ch12336
Aug 29, 2018
77f2586
implement evaluation with explanations
eli-darkly Aug 30, 2018
b3d3487
linter
eli-darkly Aug 30, 2018
223fb2c
TypeScript definitions
eli-darkly Aug 30, 2018
2218a85
reorganize and improve LDClient tests
eli-darkly Aug 30, 2018
e985934
more tests
eli-darkly Aug 30, 2018
8e6c459
substitute null for undefined in details object
eli-darkly Aug 30, 2018
53815ef
Merge branch 'eb/ch22333/explanations' into eb/break-up-client-tests
eli-darkly Aug 30, 2018
dbf7490
update null/undefined behavior
eli-darkly Aug 30, 2018
d7b4e88
Merge pull request #95 from launchdarkly/eb/ch22998/check-typescript
eli-darkly Aug 30, 2018
101a4c8
Merge pull request #96 from launchdarkly/eb/ch22333/explanations
eli-darkly Sep 6, 2018
0f0e2e3
Merge pull request #97 from launchdarkly/eb/break-up-client-tests
eli-darkly Sep 6, 2018
383abad
Merge branch 'master' into explanation
eli-darkly Sep 6, 2018
26027b0
fix allFlags
eli-darkly Sep 7, 2018
208c3c8
Merge pull request #98 from launchdarkly/eb/fix-all-flags
eli-darkly Sep 7, 2018
2808e03
linter
eli-darkly Sep 7, 2018
cc5c141
Merge branch 'master' of github.com:launchdarkly/js-client
eli-darkly Sep 7, 2018
5263c3d
add option to skip fetching goals
eli-darkly Sep 17, 2018
1a71baa
add a promise that distinguishes between successful and failed initia…
eli-darkly Sep 18, 2018
139463c
Merge pull request #99 from launchdarkly/eb/ch23985/no-goals
eli-darkly Sep 18, 2018
0804cf0
rename event, add more tests
eli-darkly Sep 19, 2018
dcf7bee
Merge pull request #100 from launchdarkly/eb/ch23989/wait-for-init
eli-darkly Sep 19, 2018
d38b0a2
add useLDHeaders option
brooswit Sep 20, 2018
92b95a3
address PR concerns
brooswit Sep 24, 2018
6474b2b
change sendLDEvents to preventLDEvents
brooswit Sep 24, 2018
4bef576
fix tests
brooswit Sep 24, 2018
0df44e1
Revert "fix tests"
eli-darkly Sep 25, 2018
94063d5
Revert "change sendLDEvents to preventLDEvents"
eli-darkly Sep 25, 2018
27a49b8
document sendLDHeaders in TypeScript file
eli-darkly Sep 25, 2018
a0f05b5
document some more options in TypeScript
eli-darkly Sep 25, 2018
2f0c22f
misc fixes
eli-darkly Sep 25, 2018
79ab6a3
linter
eli-darkly Sep 25, 2018
a4e3a26
Merge pull request #101 from launchdarkly/optional-options
eli-darkly Sep 25, 2018
827a87f
rm duplicate property definition
eli-darkly Sep 25, 2018
e5242b5
Merge branch 'master' of github.com:launchdarkly/js-client
eli-darkly Sep 25, 2018
5061020
change sendLDHeaders to only affect flag requests, not events
eli-darkly Sep 25, 2018
6208a31
linter
eli-darkly Sep 25, 2018
55482c3
Merge pull request #102 from launchdarkly/eb/keep-headers-for-events
eli-darkly Sep 27, 2018
835f74d
add unit test for sendLDHeaders at client level
eli-darkly Sep 27, 2018
cc6f361
linter
eli-darkly Sep 27, 2018
58de764
Merge pull request #104 from launchdarkly/eb/headers-unit-test
eli-darkly Sep 27, 2018
6041181
Merge branch 'master' of github.com:launchdarkly/js-client
eli-darkly Sep 28, 2018
fe63526
fix config property name in TypeScript defs
eli-darkly Oct 2, 2018
70f2795
Merge pull request #105 from launchdarkly/eb/ch24813/ts-property
eli-darkly Oct 2, 2018
1bfc4c6
[ch25429] Fix stream disconnect() by closing the EventSource (#115)
apucacao Oct 17, 2018
1f73f7e
Prepare 2.7.2
apucacao Oct 17, 2018
34fe8b6
Mention TS change in changelog
apucacao Oct 17, 2018
23429f9
update changelog entry
apucacao Oct 17, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@
All notable changes to the LaunchDarkly client-side JavaScript SDK will be documented in this file.
This project adheres to [Semantic Versioning](http://semver.org).

## [2.7.2] - 2018-10-17
### Fixed:
- Disconnecting from the stream does not close the browser tab anymore.
(Thanks, [Sawtaytoes](https://github.com/launchdarkly/js-client/issues/119).)
- The configuration property `evaluationReasons` was misnamed as `evaluationExplanations` in the TypeScript definitions.

## [2.7.1] - 2018-09-27
### Fixed:
- Event posts did not include the HTTP header that specifies the SDK version. They now do again. Note that the `sendLDHeaders` option does not affect this; if the header is turned off for flag requests, it should still be sent in events, since events always require a CORS preflight check anyway (and are delivered asynchronously, so the OPTIONS request does not slow down page loads).
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ldclient-js",
"version": "2.7.1",
"version": "2.7.2",
"description": "LaunchDarkly SDK for JavaScript",
"author": "LaunchDarkly <team@launchdarkly.com>",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion src/Stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export default function Stream(baseUrl, environment, hash, config) {
stream.disconnect = function() {
clearTimeout(reconnectTimeoutReference);
reconnectTimeoutReference = null;
close();
closeConnection();
};

stream.isConnected = function() {
Expand Down
2 changes: 1 addition & 1 deletion typings.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ declare module 'ldclient-js' {
* variationDetail() method. Since this increases the size of network requests,
* such information is not sent unless you request it with this option.
*/
evaluationExplanations?: boolean;
evaluationReasons?: boolean;

/**
* True (the default) if the client should make a request to LaunchDarkly for
Expand Down