Add safe wrappers around localStorage #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apucacao
reviewed
Dec 13, 2017
Contributor
apucacao
left a comment
apucacao
left a comment
There was a problem hiding this comment.
Thanks @mickeyreiss-visor — this look good! Special thanks for adding tests 🥇
I had one question, but other than that, 👍 .
| var Identity = require('./Identity'); | ||
| var utils = require('./utils'); | ||
| var messages = require('./messages'); | ||
| var store = require('./store'); |
Contributor
There was a problem hiding this comment.
Does it matter than we require store.js here while the module is actually named Store.js (capital S)?
Author
There was a problem hiding this comment.
Good catch. That may cause problems in some environments. Fixed!
mickeyreiss-visor
force-pushed
the
master
branch
from
b327d5a to
7a2fde4
Compare
Author
|
@apucacao pushed a fix and also rebased on |
apucacao
approved these changes
Dec 13, 2017
Contributor
|
This should go out shortly. Thanks again @mickeyreiss-visor ! |
eli-darkly
pushed a commit
that referenced
this pull request
May 7, 2018
move XMLHttpRequest into send method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@apucacao Here's an attempt at solving #55. I modeled the Store API based on store.js.
I didn't take the liberty of adding a dependency to your SDK. However, as a consumer, I'd be open to that outcome, especially given the the lightweight and and robust nature of this particular library.