feat: Remove event target shim. #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanderson-ld
approved these changes
Aug 15, 2024
Merged
kinyoklion
pushed a commit
that referenced
this pull request
Aug 16, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>js-client-sdk-common: 1.4.0</summary> ## [1.4.0](js-client-sdk-common-v1.3.0...js-client-sdk-common-v1.4.0) (2024-08-15) ### Features * Remove event target shim. ([#545](#545)) ([448ad67](448ad67)), closes [#412](#412) </details> <details><summary>react-native-client-sdk: 10.5.0</summary> ## [10.5.0](react-native-client-sdk-v10.4.0...react-native-client-sdk-v10.5.0) (2024-08-15) ### Features * Remove event target shim. ([#545](#545)) ([448ad67](448ad67)), closes [#412](#412) ### Dependencies * The following workspace dependencies were updated * dependencies * @launchdarkly/js-client-sdk-common bumped from 1.3.0 to 1.4.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike the EventEmitter in the node SDK the EventTarget was not providing an interface directly on the LDClient. The LDClient has its own off/on interface which is not directly implemented via an event target. Which means removing it simplifies the implementation instead of complicating it.
Second it is in the common code and node in a leaf implementation. Which means it requires a polyfill where it is not supported. Like when using hermes with React Native.
Typically we dispatch using a micro-task, but EventTarget dispatches synchronously. For now this maintains the synchronous behavior.
Fixes: #412