Skip to content

ci: consolidate test harness adapter server#1217

Merged
joker23 merged 6 commits into
mainfrom
skz/sdk-2046/contract-test-adapter-server
Mar 24, 2026
Merged

ci: consolidate test harness adapter server#1217
joker23 merged 6 commits into
mainfrom
skz/sdk-2046/contract-test-adapter-server

Conversation

@joker23

@joker23 joker23 commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

This PR will implement the SDK testharness adapter server to the shared utils.

This should also stabilize some of the flaky ci tests since we not longer depend on a full repo build to ensure all contract test dependencies are built


Note

Medium Risk
Medium risk because it changes how contract-test infrastructure is built and launched in CI/local scripts, which can break contract test pipelines despite not affecting production runtime.

Overview
Consolidates the browser and React Native contract-test adapter servers into @launchdarkly/js-contract-test-utils, adding an exported startAdapter() API plus a new sdk-testharness-server/sts CLI with configurable ports.

Removes the standalone browser-contract-test-adapter and react-native-contract-test-adapter workspaces, updates contract-test entity packages to start the adapter via start:adapter, and simplifies GitHub Actions workflows to focus/build only the needed workspaces (including updated cleanup process matching the new CLI).

Adjusts TypeScript build config in contract-test-utils to compile the new adapter/CLI entrypoints, and fixes contract-test ESLint configs by setting tsconfigRootDir for React and server-node.

Written by Cursor Bugbot for commit ebef965. This will update automatically on new commits. Configure here.


Open with Devin

@joker23 joker23 force-pushed the skz/sdk-2046/contract-test-adapter-server branch from acc2504 to ed57661 Compare March 23, 2026 21:23
@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25661 bytes
Compressed size limit: 29000
Uncompressed size: 126143 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 25042 bytes
Compressed size limit: 34000
Uncompressed size: 87384 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 172878 bytes
Compressed size limit: 200000
Uncompressed size: 804511 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 29404 bytes
Compressed size limit: 38000
Uncompressed size: 158016 bytes

@joker23 joker23 marked this pull request as ready for review March 24, 2026 18:37
@joker23 joker23 requested a review from a team as a code owner March 24, 2026 18:37

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

@joker23

joker23 commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@joker23 joker23 merged commit 86110d7 into main Mar 24, 2026
46 checks passed
@joker23 joker23 deleted the skz/sdk-2046/contract-test-adapter-server branch March 24, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants