Skip to content

ci(react-sdk): update example app sdk version#1234

Merged
joker23 merged 1 commit into
mainfrom
skz/react-example-version
Mar 30, 2026
Merged

ci(react-sdk): update example app sdk version#1234
joker23 merged 1 commit into
mainfrom
skz/react-example-version

Conversation

@joker23

@joker23 joker23 commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

This PR will:

  1. update release please config to update the react example app sdk versions
  2. convert the react example apps to use pinned sdk versions instead of workspace^
  3. added env to skip electron binary download in react contract test to address flaky behavior

Note

Low Risk
Low risk: changes are limited to CI environment variables and dependency version pinning in example apps plus release automation config updates.

Overview
Improves React SDK contract-test CI reliability by setting ELECTRON_SKIP_BINARY_DOWNLOAD=1 during dependency installation to avoid flaky concurrent Electron downloads.

Updates the server-only React example to use pinned published versions of @launchdarkly/react-sdk and @launchdarkly/node-server-sdk (instead of workspace:^), and extends release-please-config.json so releases automatically bump the SDK dependency versions in the hello-react and server-only example package.json files.

Written by Cursor Bugbot for commit 94f9df8. This will update automatically on new commits. Configure here.


Open with Devin

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25661 bytes
Compressed size limit: 29000
Uncompressed size: 126143 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179146 bytes
Compressed size limit: 200000
Uncompressed size: 828569 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 36775 bytes
Compressed size limit: 38000
Uncompressed size: 201898 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31371 bytes
Compressed size limit: 34000
Uncompressed size: 111380 bytes

@joker23

joker23 commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@joker23 joker23 marked this pull request as ready for review March 30, 2026 15:42
@joker23 joker23 requested a review from a team as a code owner March 30, 2026 15:42
"src/client/LDReactClient.tsx",
{
"type": "json",
"path": "examples/hello-react/package.json",

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example was already using the pinned sdk version

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@joker23 joker23 merged commit 62d1d08 into main Mar 30, 2026
47 checks passed
@joker23 joker23 deleted the skz/react-example-version branch March 30, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants