Skip to content

fix(electron): correcting package.json versions#1267

Merged
joker23 merged 1 commit into
mainfrom
skz/sdk-2162/electron-ci
Apr 14, 2026
Merged

fix(electron): correcting package.json versions#1267
joker23 merged 1 commit into
mainfrom
skz/sdk-2162/electron-ci

Conversation

@joker23

@joker23 joker23 commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Adjusts peerDependencies for Electron packages, which can change install-time compatibility for consumers using older Electron versions. No runtime logic changes, but dependency resolution/build pipelines may be affected.

Overview
Updates Electron package manifests to better reflect supported Electron versions.

@launchdarkly/electron-client-sdk now declares an Electron peer requirement of >=34.5.6 (instead of *), and the example and contract-tests packages add explicit peerDependencies matching their Electron devDependency versions.

Reviewed by Cursor Bugbot for commit 6e1f307. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 25623 bytes
Compressed size limit: 29000
Uncompressed size: 125843 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/browser size report
This is the brotli compressed size of the ESM build.
Compressed size: 179372 bytes
Compressed size limit: 200000
Uncompressed size: 829982 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 31649 bytes
Compressed size limit: 34000
Uncompressed size: 112792 bytes

@github-actions

Copy link
Copy Markdown
Contributor

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 37169 bytes
Compressed size limit: 38000
Uncompressed size: 204305 bytes

@joker23 joker23 force-pushed the skz/sdk-2162/electron-ci branch from 971aa4d to 0929005 Compare April 13, 2026 20:23
@joker23

joker23 commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

cursor[bot]

This comment was marked as resolved.

@joker23 joker23 force-pushed the skz/sdk-2162/electron-ci branch from 0929005 to 6e1f307 Compare April 13, 2026 21:03
@joker23

joker23 commented Apr 13, 2026

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 6e1f307. Configure here.

@joker23 joker23 marked this pull request as ready for review April 13, 2026 21:11
@joker23 joker23 requested a review from a team as a code owner April 13, 2026 21:11

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@joker23 joker23 merged commit 40c36f5 into main Apr 14, 2026
44 checks passed
@joker23 joker23 deleted the skz/sdk-2162/electron-ci branch April 14, 2026 16:27
@github-actions github-actions Bot mentioned this pull request Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants