chore: conditional import of AsyncStorage #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore tests for synchronization.
…n check for patch and delete. added test for inExperiment.
…nges. add patch and delete unit tests. mock streamer now supports patch and delete commands.
… infinite loop when flag is deleted.
… unused apis and options.
This implements feedback from #326. * Run synchronization logic for all `change` events. * Removed `ready` event and use `change` instead. * Callback argument for `change` is now just a string array of flag keys. * Removed config options `stream` and `useReport` for now for this alpha.
…ndependent yarn project.
…ilable. Dynamic import works. TODO: fix bundling invariant error where AsyncStorage is no longer available.
…async storage package works.
yusinto
requested review from
kinyoklion and
louis-launchdarkly
as code owners
|
This pull request has been linked to Shortcut Story #227636: RN should import AsyncStorage conditionally for backwards compatibility. |
louis-launchdarkly
approved these changes
Dec 22, 2023
yusinto
deleted the
yus/sc-227636/rn-should-import-asyncstorage-conditionally
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally import AsyncStorage for backwards compatibility with RN < 0.71.