From 985ed2af01f8d54c4eb39f14bb0571d1accc9d59 Mon Sep 17 00:00:00 2001 From: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Date: Tue, 10 Sep 2024 09:34:07 -0700 Subject: [PATCH 1/2] feat: Add browser info. --- .../sdk/browser/src/platform/BrowserInfo.ts | 17 +++++++++++++++++ .../sdk/browser/src/platform/BrowserPlatform.ts | 13 +++++-------- 2 files changed, 22 insertions(+), 8 deletions(-) create mode 100644 packages/sdk/browser/src/platform/BrowserInfo.ts diff --git a/packages/sdk/browser/src/platform/BrowserInfo.ts b/packages/sdk/browser/src/platform/BrowserInfo.ts new file mode 100644 index 0000000000..54d9585af4 --- /dev/null +++ b/packages/sdk/browser/src/platform/BrowserInfo.ts @@ -0,0 +1,17 @@ +import { Info, PlatformData, SdkData } from '@launchdarkly/js-client-sdk-common'; +import { name, version } from '../../package.json'; + +export default class BrowserInfo implements Info { + platformData(): PlatformData { + return { + name: 'JS' // Name maintained from previous 3.x implementation. + }; + } + sdkData(): SdkData { + return { + name, + version, + userAgentBase: 'JSClient' + }; + } +} diff --git a/packages/sdk/browser/src/platform/BrowserPlatform.ts b/packages/sdk/browser/src/platform/BrowserPlatform.ts index 8865ebc3c8..4bdedead88 100644 --- a/packages/sdk/browser/src/platform/BrowserPlatform.ts +++ b/packages/sdk/browser/src/platform/BrowserPlatform.ts @@ -1,16 +1,13 @@ -import { - Crypto, - /* platform */ - LDOptions, - Storage, -} from '@launchdarkly/js-client-sdk-common'; +import { Crypto, Encoding, Info, LDOptions, Storage } from '@launchdarkly/js-client-sdk-common'; import BrowserCrypto from './BrowserCrypto'; +import BrowserEncoding from './BrowserEncoding'; +import BrowserInfo from './BrowserInfo'; import LocalStorage, { isLocalStorageSupported } from './LocalStorage'; export default class BrowserPlatform /* implements platform.Platform */ { - // encoding?: Encoding; - // info: Info; + encoding?: Encoding = new BrowserEncoding(); + info: Info = new BrowserInfo(); // fileSystem?: Filesystem; crypto: Crypto = new BrowserCrypto(); // requests: Requests; From 7b07258427deae8907dae3ee2629dec9249a8878 Mon Sep 17 00:00:00 2001 From: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Date: Tue, 10 Sep 2024 10:11:09 -0700 Subject: [PATCH 2/2] Lint --- packages/sdk/browser/src/platform/BrowserInfo.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/sdk/browser/src/platform/BrowserInfo.ts b/packages/sdk/browser/src/platform/BrowserInfo.ts index 54d9585af4..637ebad50b 100644 --- a/packages/sdk/browser/src/platform/BrowserInfo.ts +++ b/packages/sdk/browser/src/platform/BrowserInfo.ts @@ -1,17 +1,18 @@ import { Info, PlatformData, SdkData } from '@launchdarkly/js-client-sdk-common'; + import { name, version } from '../../package.json'; export default class BrowserInfo implements Info { platformData(): PlatformData { return { - name: 'JS' // Name maintained from previous 3.x implementation. + name: 'JS', // Name maintained from previous 3.x implementation. }; } sdkData(): SdkData { return { name, version, - userAgentBase: 'JSClient' + userAgentBase: 'JSClient', }; } }