From 9e941451d4fc2b9df7be2375d7a970f3aec8634b Mon Sep 17 00:00:00 2001 From: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Date: Thu, 10 Oct 2024 15:53:12 -0700 Subject: [PATCH 1/2] fix: Do not mangle _meta. --- packages/sdk/browser/rollup.config.js | 25 +++++++++++-------------- 1 file changed, 11 insertions(+), 14 deletions(-) diff --git a/packages/sdk/browser/rollup.config.js b/packages/sdk/browser/rollup.config.js index 4ac9311845..1b075ccd73 100644 --- a/packages/sdk/browser/rollup.config.js +++ b/packages/sdk/browser/rollup.config.js @@ -21,6 +21,15 @@ const getSharedConfig = (format, file) => ({ }, }); +const terserOpts = { + mangle: { + properties: { + regex: /^_/, + reserved: ['_meta'] + }, + } +}; + export default [ { ...getSharedConfig('es', 'dist/index.es.js'), @@ -33,13 +42,7 @@ export default [ esmExternals: true, }), resolve(), - terser({ - mangle: { - properties: { - regex: /^_/, - }, - }, - }), + terser(terserOpts), json(), // The 'sourcemap' option allows using the minified size, not the size before minification. visualizer({ sourcemap: true }), @@ -51,13 +54,7 @@ export default [ typescript(), common(), resolve(), - terser({ - mangle: { - properties: { - regex: /^_/, - }, - }, - }), + terser(terserOpts), json(), ], }, From 733fb50d553bd331d9a35e0e0992b99a820f65d9 Mon Sep 17 00:00:00 2001 From: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Date: Fri, 11 Oct 2024 08:19:40 -0700 Subject: [PATCH 2/2] Comments --- packages/sdk/browser/rollup.config.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/sdk/browser/rollup.config.js b/packages/sdk/browser/rollup.config.js index 1b075ccd73..550533ccf1 100644 --- a/packages/sdk/browser/rollup.config.js +++ b/packages/sdk/browser/rollup.config.js @@ -24,7 +24,10 @@ const getSharedConfig = (format, file) => ({ const terserOpts = { mangle: { properties: { + // Mangle class properties which start with an underscore. regex: /^_/, + // Do not mangle '_meta', because this is part of our JSON + // data model. reserved: ['_meta'] }, }