From 7877e11683369d276201ec2f2dc2b4a45b74155a Mon Sep 17 00:00:00 2001 From: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Date: Tue, 12 Nov 2024 12:57:30 -0800 Subject: [PATCH 1/2] fix: Update default typings to include enabled. --- packages/sdk/server-ai/src/api/LDAIClient.ts | 10 ++++++++-- packages/sdk/server-ai/src/api/config/LDAIConfig.ts | 11 +++++++++++ 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/packages/sdk/server-ai/src/api/LDAIClient.ts b/packages/sdk/server-ai/src/api/LDAIClient.ts index 990485819c..1ef1a474cc 100644 --- a/packages/sdk/server-ai/src/api/LDAIClient.ts +++ b/packages/sdk/server-ai/src/api/LDAIClient.ts @@ -2,10 +2,16 @@ import { LDContext } from '@launchdarkly/js-server-sdk-common'; import { LDAIConfig, LDGenerationConfig } from './config/LDAIConfig'; +export interface LDAIDefaults extends LDGenerationConfig { + /** + * Whether the configuration is enabled. + */ + enabled?: boolean; +} + /** * Interface for performing AI operations using LaunchDarkly. */ - export interface LDAIClient { /** * Parses and interpolates a template string with the provided variables. @@ -68,7 +74,7 @@ export interface LDAIClient { * } * ``` */ - modelConfig( + modelConfig( key: string, context: LDContext, defaultValue: TDefault, diff --git a/packages/sdk/server-ai/src/api/config/LDAIConfig.ts b/packages/sdk/server-ai/src/api/config/LDAIConfig.ts index 0d47f6eac0..432a0a7327 100644 --- a/packages/sdk/server-ai/src/api/config/LDAIConfig.ts +++ b/packages/sdk/server-ai/src/api/config/LDAIConfig.ts @@ -9,6 +9,17 @@ export interface LDModelConfig { */ modelId?: string; + /** + * Tuning parameter for randomness versus determinism. Exact effect will be determined by the + * model. + */ + temperature?: number; + + /** + * The maximum number of tokens. + */ + maxTokens?: number; + /** * And additional model specific information. */ From b8638b2e8683288aff7ddd82998da09b4ee0f41c Mon Sep 17 00:00:00 2001 From: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Date: Tue, 12 Nov 2024 13:02:12 -0800 Subject: [PATCH 2/2] More comments. --- packages/sdk/server-ai/src/api/LDAIClient.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/sdk/server-ai/src/api/LDAIClient.ts b/packages/sdk/server-ai/src/api/LDAIClient.ts index 1ef1a474cc..cffd657a7c 100644 --- a/packages/sdk/server-ai/src/api/LDAIClient.ts +++ b/packages/sdk/server-ai/src/api/LDAIClient.ts @@ -2,6 +2,9 @@ import { LDContext } from '@launchdarkly/js-server-sdk-common'; import { LDAIConfig, LDGenerationConfig } from './config/LDAIConfig'; +/** + * Interface for default model configuration. + */ export interface LDAIDefaults extends LDGenerationConfig { /** * Whether the configuration is enabled.