From 0c169b63b391489670573228985a2a22f83bda1d Mon Sep 17 00:00:00 2001
From: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Date: Tue, 21 Jan 2025 11:29:13 -0800
Subject: [PATCH 1/2] fix: Fix breadcrumb filter option parsing.

---
 .../browser-telemetry/__tests__/options.test.ts          | 9 ++++++---
 packages/telemetry/browser-telemetry/src/options.ts      | 8 +++++++-
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/packages/telemetry/browser-telemetry/__tests__/options.test.ts b/packages/telemetry/browser-telemetry/__tests__/options.test.ts
index c4d543ba45..db6bc15a37 100644
--- a/packages/telemetry/browser-telemetry/__tests__/options.test.ts
+++ b/packages/telemetry/browser-telemetry/__tests__/options.test.ts
@@ -1,3 +1,4 @@
+import { Breadcrumb } from '../src/api/Breadcrumb';
 import ErrorCollector from '../src/collectors/error';
 import parse, { defaultOptions } from '../src/options';
 
@@ -15,6 +16,7 @@ it('handles an empty configuration', () => {
 });
 
 it('can set all options at once', () => {
+  const filter = (breadcrumb: Breadcrumb) => breadcrumb;
   const outOptions = parse({
     maxPendingEvents: 1,
     breadcrumbs: {
@@ -22,7 +24,7 @@ it('can set all options at once', () => {
       click: false,
       evaluations: false,
       flagChange: false,
-      filters: [(breadcrumb) => breadcrumb],
+      filters: [filter],
     },
     collectors: [new ErrorCollector(), new ErrorCollector()],
   });
@@ -39,7 +41,7 @@ it('can set all options at once', () => {
         instrumentFetch: true,
         instrumentXhr: true,
       },
-      filters: expect.any(Array),
+      filters: expect.arrayContaining([filter]),
     },
     stack: {
       source: {
@@ -50,6 +52,7 @@ it('can set all options at once', () => {
     },
     collectors: [new ErrorCollector(), new ErrorCollector()],
   });
+  expect(mockLogger.warn).not.toHaveBeenCalled();
 });
 
 it('warns when maxPendingEvents is not a number', () => {
@@ -435,6 +438,6 @@ it('warns when filters is not an array', () => {
   );
   expect(outOptions.breadcrumbs.filters).toEqual([]);
   expect(mockLogger.warn).toHaveBeenCalledWith(
-    'LaunchDarkly - Browser Telemetry: Config option "breadcrumbs.filters" should be of type array, got string, using default value',
+    'LaunchDarkly - Browser Telemetry: Config option "breadcrumbs.filters" should be of type BreadcrumbFilter[], got string, using default value',
   );
 });
diff --git a/packages/telemetry/browser-telemetry/src/options.ts b/packages/telemetry/browser-telemetry/src/options.ts
index af5620026f..80b3c37198 100644
--- a/packages/telemetry/browser-telemetry/src/options.ts
+++ b/packages/telemetry/browser-telemetry/src/options.ts
@@ -190,7 +190,13 @@ export default function parse(options: Options, logger?: MinLogger): ParsedOptio
       filters: itemOrDefault(
         options.breadcrumbs?.filters,
         defaults.breadcrumbs.filters,
-        checkBasic('array', 'breadcrumbs.filters', logger),
+        (item) => {
+          if (Array.isArray(item)) {
+            return true;
+          }
+          logger?.warn(wrongOptionType('breadcrumbs.filters', 'BreadcrumbFilter[]', typeof item));
+          return false;
+        },
       ),
     },
     stack: parseStack(options.stack, defaults.stack),

From e788d359cd8f10ef752b878af9c957840ea0ff2e Mon Sep 17 00:00:00 2001
From: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Date: Tue, 21 Jan 2025 11:31:20 -0800
Subject: [PATCH 2/2] Lint

---
 .../telemetry/browser-telemetry/src/options.ts | 18 +++++++-----------
 1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/packages/telemetry/browser-telemetry/src/options.ts b/packages/telemetry/browser-telemetry/src/options.ts
index 80b3c37198..0b14615dd4 100644
--- a/packages/telemetry/browser-telemetry/src/options.ts
+++ b/packages/telemetry/browser-telemetry/src/options.ts
@@ -187,17 +187,13 @@ export default function parse(options: Options, logger?: MinLogger): ParsedOptio
         checkBasic('boolean', 'breadcrumbs.keyboardInput', logger),
       ),
       http: parseHttp(options.breadcrumbs?.http, defaults.breadcrumbs.http, logger),
-      filters: itemOrDefault(
-        options.breadcrumbs?.filters,
-        defaults.breadcrumbs.filters,
-        (item) => {
-          if (Array.isArray(item)) {
-            return true;
-          }
-          logger?.warn(wrongOptionType('breadcrumbs.filters', 'BreadcrumbFilter[]', typeof item));
-          return false;
-        },
-      ),
+      filters: itemOrDefault(options.breadcrumbs?.filters, defaults.breadcrumbs.filters, (item) => {
+        if (Array.isArray(item)) {
+          return true;
+        }
+        logger?.warn(wrongOptionType('breadcrumbs.filters', 'BreadcrumbFilter[]', typeof item));
+        return false;
+      }),
     },
     stack: parseStack(options.stack, defaults.stack),
     maxPendingEvents: itemOrDefault(