Skip to content

Conversation

@cwaldren-ld
Copy link
Contributor

@cwaldren-ld cwaldren-ld commented Mar 8, 2024

It's quite awkward to document ad-hoc tables in Lua created via the C API. Prior to this PR, the EvaluationDetail table returned from *variationDetail methods didn't have any explanation.

This PR adds documentation of the various fields. Since there's no actual table to document (it's created via C API), the docs are just sort of floating in the file as a comment.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #232968: Improve documentation of EvaluationDetail table.

@cwaldren-ld cwaldren-ld marked this pull request as ready for review March 8, 2024 21:17
@cwaldren-ld cwaldren-ld requested review from a team and louis-launchdarkly March 8, 2024 21:17
@cwaldren-ld cwaldren-ld merged commit efe82f7 into main Mar 11, 2024
@cwaldren-ld cwaldren-ld deleted the cw/sc-232968/better-table-documentation branch March 11, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants