From 07b69894043842620837d001ca65d6a8a7ec9852 Mon Sep 17 00:00:00 2001 From: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Date: Wed, 14 Jun 2023 14:02:29 -0700 Subject: [PATCH 1/2] Update for node SDK 8 release. --- README.md | 4 ++-- __tests__/LaunchDarklyProvider.test.ts | 2 +- __tests__/SafeLogger.test.ts | 2 +- __tests__/TestLogger.ts | 2 +- package.json | 4 ++-- src/LaunchDarklyProvider.ts | 2 +- src/LaunchDarklyProviderOptions.ts | 2 +- src/SafeLogger.ts | 2 +- src/translateContext.ts | 2 +- src/translateResult.ts | 2 +- 10 files changed, 12 insertions(+), 12 deletions(-) diff --git a/README.md b/README.md index ad8c2ea..3750913 100644 --- a/README.md +++ b/README.md @@ -22,14 +22,14 @@ This version of the LaunchDarkly OpenFeature provider is compatible with Node.js ``` npm install @openfeature/js-sdk -npm install launchdarkly-node-server-sdk +npm install @launchdarkly/node-server-sdk npm install @launchdarkly/openfeature-node-server ``` ### Usage ``` import { OpenFeature } from '@openfeature/js-sdk'; -import { init } from 'launchdarkly-node-server-sdk'; +import { init } from '@launchdarkly/node-server-sdk'; import { LaunchDarklyProvider } from '@launchdarkly/openfeature-node-server'; diff --git a/__tests__/LaunchDarklyProvider.test.ts b/__tests__/LaunchDarklyProvider.test.ts index fa0a72d..fc521cb 100644 --- a/__tests__/LaunchDarklyProvider.test.ts +++ b/__tests__/LaunchDarklyProvider.test.ts @@ -1,5 +1,5 @@ import { OpenFeature, Client, ErrorCode } from '@openfeature/js-sdk'; -import { LDClient } from 'launchdarkly-node-server-sdk'; +import { LDClient } from '@launchdarkly/node-server-sdk'; import { LaunchDarklyProvider } from '../src'; import translateContext from '../src/translateContext'; import TestLogger from './TestLogger'; diff --git a/__tests__/SafeLogger.test.ts b/__tests__/SafeLogger.test.ts index c716013..6e978e8 100644 --- a/__tests__/SafeLogger.test.ts +++ b/__tests__/SafeLogger.test.ts @@ -1,4 +1,4 @@ -import { basicLogger, LDLogger } from 'launchdarkly-node-server-sdk'; +import { basicLogger, LDLogger } from '@launchdarkly/node-server-sdk'; import SafeLogger from '../src/SafeLogger'; it('throws when constructed with an invalid logger', () => { diff --git a/__tests__/TestLogger.ts b/__tests__/TestLogger.ts index e70c6ac..dba8e24 100644 --- a/__tests__/TestLogger.ts +++ b/__tests__/TestLogger.ts @@ -1,4 +1,4 @@ -import { LDLogger } from 'launchdarkly-node-server-sdk'; +import { LDLogger } from '@launchdarkly/node-server-sdk'; export default class TestLogger implements LDLogger { public logs: string[] = []; diff --git a/package.json b/package.json index 740d012..a2c9a1d 100644 --- a/package.json +++ b/package.json @@ -21,7 +21,7 @@ "license": "Apache-2.0", "peerDependencies": { "@openfeature/js-sdk": "^1.0.0", - "launchdarkly-node-server-sdk": "7.x" + "@launchdarkly/node-server-sdk": "8.x" }, "devDependencies": { "@openfeature/js-sdk": "^1.0.0", @@ -34,7 +34,7 @@ "eslint-plugin-import": "^2.26.0", "jest": "^27.5.1", "jest-junit": "^14.0.1", - "launchdarkly-node-server-sdk": "7.x", + "@launchdarkly/node-server-sdk": "8.x", "ts-jest": "^27.1.4", "typescript": "^4.7.4" } diff --git a/src/LaunchDarklyProvider.ts b/src/LaunchDarklyProvider.ts index 227ac9e..8329197 100644 --- a/src/LaunchDarklyProvider.ts +++ b/src/LaunchDarklyProvider.ts @@ -6,7 +6,7 @@ import { } from '@openfeature/js-sdk'; import { basicLogger, LDClient, LDLogger, -} from 'launchdarkly-node-server-sdk'; +} from '@launchdarkly/node-server-sdk'; import { LaunchDarklyProviderOptions } from './LaunchDarklyProviderOptions'; import translateContext from './translateContext'; import translateResult from './translateResult'; diff --git a/src/LaunchDarklyProviderOptions.ts b/src/LaunchDarklyProviderOptions.ts index cb1d301..7a9a000 100644 --- a/src/LaunchDarklyProviderOptions.ts +++ b/src/LaunchDarklyProviderOptions.ts @@ -1,4 +1,4 @@ -import { LDLogger } from 'launchdarkly-node-server-sdk'; +import { LDLogger } from '@launchdarkly/node-server-sdk'; /** * Options for the {@link LaunchDarklyProvider}. diff --git a/src/SafeLogger.ts b/src/SafeLogger.ts index 2ac7f19..0576cef 100644 --- a/src/SafeLogger.ts +++ b/src/SafeLogger.ts @@ -1,4 +1,4 @@ -import { LDLogger } from 'launchdarkly-node-server-sdk'; +import { LDLogger } from '@launchdarkly/node-server-sdk'; /** * Logging levels. Each should correspond to a method on the logger. diff --git a/src/translateContext.ts b/src/translateContext.ts index 80bf067..9a098b8 100644 --- a/src/translateContext.ts +++ b/src/translateContext.ts @@ -1,7 +1,7 @@ import { EvaluationContext, EvaluationContextValue } from '@openfeature/js-sdk'; import { LDContext, LDContextCommon, LDLogger, LDSingleKindContext, -} from 'launchdarkly-node-server-sdk'; +} from '@launchdarkly/node-server-sdk'; const LDContextBuiltIns = { name: 'string', diff --git a/src/translateResult.ts b/src/translateResult.ts index a9dcbc0..5d8ae66 100644 --- a/src/translateResult.ts +++ b/src/translateResult.ts @@ -1,5 +1,5 @@ import { ErrorCode, ResolutionDetails } from '@openfeature/js-sdk'; -import { LDEvaluationDetail } from 'launchdarkly-node-server-sdk'; +import { LDEvaluationDetail } from '@launchdarkly/node-server-sdk'; /** * Convert an `errorKind` into an OpenFeature `errorCode`. From 420f28773c25b98a2d2d55fb825dc9125230c224 Mon Sep 17 00:00:00 2001 From: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com> Date: Wed, 14 Jun 2023 14:09:09 -0700 Subject: [PATCH 2/2] Update tests for changes to OF SDK. --- __tests__/LaunchDarklyProvider.test.ts | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/__tests__/LaunchDarklyProvider.test.ts b/__tests__/LaunchDarklyProvider.test.ts index fc521cb..1391769 100644 --- a/__tests__/LaunchDarklyProvider.test.ts +++ b/__tests__/LaunchDarklyProvider.test.ts @@ -45,7 +45,7 @@ describe('given a mock LaunchDarkly client', () => { }, })); const res = await ofClient.getBooleanDetails(testFlagKey, false, basicContext); - expect(res).toEqual({ + expect(res).toMatchObject({ flagKey: testFlagKey, value: true, reason: 'OFF', @@ -60,7 +60,7 @@ describe('given a mock LaunchDarkly client', () => { }, })); const res = await ofClient.getBooleanDetails(testFlagKey, false, basicContext); - expect(res).toEqual({ + expect(res).toMatchObject({ flagKey: testFlagKey, value: false, reason: 'ERROR', @@ -92,7 +92,7 @@ describe('given a mock LaunchDarkly client', () => { }, })); const res = await ofClient.getStringDetails(testFlagKey, 'default', basicContext); - expect(res).toEqual({ + expect(res).toMatchObject({ flagKey: testFlagKey, value: 'good', reason: 'OFF', @@ -107,7 +107,7 @@ describe('given a mock LaunchDarkly client', () => { }, })); const res = await ofClient.getStringDetails(testFlagKey, 'default', basicContext); - expect(res).toEqual({ + expect(res).toMatchObject({ flagKey: testFlagKey, value: 'default', reason: 'ERROR', @@ -139,7 +139,7 @@ describe('given a mock LaunchDarkly client', () => { }, })); const res = await ofClient.getNumberDetails(testFlagKey, 0, basicContext); - expect(res).toEqual({ + expect(res).toMatchObject({ flagKey: testFlagKey, value: 17, reason: 'OFF', @@ -154,7 +154,7 @@ describe('given a mock LaunchDarkly client', () => { }, })); const res = await ofClient.getNumberDetails(testFlagKey, 0, basicContext); - expect(res).toEqual({ + expect(res).toMatchObject({ flagKey: testFlagKey, value: 0, reason: 'ERROR', @@ -186,7 +186,7 @@ describe('given a mock LaunchDarkly client', () => { }, })); const res = await ofClient.getObjectDetails(testFlagKey, {}, basicContext); - expect(res).toEqual({ + expect(res).toMatchObject({ flagKey: testFlagKey, value: { some: 'value' }, reason: 'OFF', @@ -201,7 +201,7 @@ describe('given a mock LaunchDarkly client', () => { }, })); const res = await ofClient.getObjectDetails(testFlagKey, {}, basicContext); - expect(res).toEqual({ + expect(res).toMatchObject({ flagKey: testFlagKey, value: {}, reason: 'ERROR', @@ -225,7 +225,7 @@ describe('given a mock LaunchDarkly client', () => { }, })); const res = await ofClient.getObjectDetails(testFlagKey, {}, basicContext); - expect(res).toEqual({ + expect(res).toMatchObject({ flagKey: testFlagKey, value: { yes: 'no' }, reason: 'ERROR', @@ -242,7 +242,7 @@ describe('given a mock LaunchDarkly client', () => { }, })); const res = await ofClient.getObjectDetails(testFlagKey, {}, basicContext); - expect(res).toEqual({ + expect(res).toMatchObject({ flagKey: testFlagKey, value: { yes: 'no' }, variant: '22',