add integration tests to CircleCI #58
Conversation
|
@drichelson please review. integration tests pass in CircleCI (php56) and in Vagrant (php54 and php55). |
…ture, e.g. \LaunchDarkly\Tests\FeatureFlagTest::$json1 and \LaunchDarkly\Tests\FeatureFlagTest::$json2.
…ly installs php54 with APC, and switches php version.
…eCI and installs apcu extension on php56. add APCU-feature-requester which is the >=php55 version of the <=php54 APC-feature-requester.
|
@drichelson thanks : ) let me know if there's anything else i can do for this one. fyi, if this is merged it should merge my other two open requests since this one is based on those. i have plans to drop php54 from the Vagrant VM, and to add Redis Sentinel support (which is why i started contributing in the first place : P). thanks again for all the review you've done for me. |
| @@ -0,0 +1,31 @@ | |||
| #!/bin/bash | |||
|
|
|||
There was a problem hiding this comment.
One thing we have found useful in shell scripts is to add this line:
set -uxe
at line 2 which will do some handy things described here
(I'll add the lines once it is merged)
There was a problem hiding this comment.
i'll add it right now in my drop-php54 branch lol i should really read the comment in its entirety before replying.
2 participants
depends on #56 and #57 .
first of all, i apologize sincerely for the nesting-doll pull-requests. it is suboptimal but i think that isolating the previous submissions lessens the cognitive load of this one, my coup de grace.
run integration tests in Vagrant php54
run integration tests in Vagrant php55
the whole shebang