fix: Fix overly generic type hint on File data source #365
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
force-pushed
the
mk/sdk-1526/typehints
branch
from
76a5d03 to
d494584
Compare
kinyoklion
approved these changes
Oct 30, 2025
keelerm84
pushed a commit
that referenced
this pull request
Oct 30, 2025
🤖 I have created a release *beep* *boop* --- ## [9.12.3](9.12.2...9.12.3) (2025-10-30) ### Bug Fixes * Fix overly generic type hint on File data source ([#365](#365)) ([52a7499](52a7499)), closes [#364](#364) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Release 9.12.3 with a bug fix note and synchronized version updates across files. > > - **Release 9.12.3**: > - Update versions in `.release-please-manifest.json`, `ldclient/version.py`, and `pyproject.toml` to `9.12.3`. > - Update `PROVENANCE.md` example `SDK_VERSION` to `9.12.3`. > - Add CHANGELOG entry for 9.12.3 noting bug fix: fix overly generic type hint on File data source (`CHANGELOG.md`). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit f392afa. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #364
Note
Refines
Files.new_data_sourcetyping and adds corresponding imports, with no runtime logic changes.Files.new_data_sourcereturn type toOptional[Callable[[Config, FeatureStore, Event], UpdateProcessor]].Event,Callable,Config,FeatureStore,UpdateProcessor.Written by Cursor Bugbot for commit d494584. This will update automatically on new commits. Configure here.