diff --git a/lib/ldclient-rb/impl/integrations/redis_impl.rb b/lib/ldclient-rb/impl/integrations/redis_impl.rb index cb7fb6c3..0a0a3a2e 100644 --- a/lib/ldclient-rb/impl/integrations/redis_impl.rb +++ b/lib/ldclient-rb/impl/integrations/redis_impl.rb @@ -112,7 +112,7 @@ def initialize(opts) @pool = create_redis_pool(opts) # shutdown pool on close unless the client passed a custom pool and specified not to shutdown - @pool_shutdown_on_close = (!opts[:pool] || opts.fetch(:pool_shutdown_on_close, true)) + @pool_shutdown_on_close = !opts[:pool] || opts.fetch(:pool_shutdown_on_close, true) @prefix = opts[:prefix] || LaunchDarkly::Integrations::Redis::default_prefix @logger = opts[:logger] || Config.default_logger diff --git a/lib/ldclient-rb/ldclient.rb b/lib/ldclient-rb/ldclient.rb index 2afba39c..e2c9fd26 100644 --- a/lib/ldclient-rb/ldclient.rb +++ b/lib/ldclient-rb/ldclient.rb @@ -87,6 +87,7 @@ def initialize(sdk_key, config = Config.default, wait_for_sec = 5) if @config.use_ldd? @config.logger.info { "[LDClient] Started LaunchDarkly Client in LDD mode" } + @data_source = NullUpdateProcessor.new return # requestor and update processor are not used in this mode end diff --git a/spec/ldclient_spec.rb b/spec/ldclient_spec.rb index ce993b41..2f78fae1 100644 --- a/spec/ldclient_spec.rb +++ b/spec/ldclient_spec.rb @@ -45,6 +45,23 @@ module LaunchDarkly end end + context "client can be stopped" do + it "when in online mode" do + client = subject.new("sdk-key", Config.new) + client.close() + end + + it "when in offline mode" do + client = subject.new("sdk-key", Config.new(offline: true)) + client.close() + end + + it "when in ldd mode" do + client = subject.new("sdk-key", Config.new(use_ldd: true)) + client.close() + end + end + context "secure_mode_hash" do it "will return the expected value for a known message and secret" do ensure_close(subject.new("secret", test_config)) do |client|