From 587243ec2237ae4d9a3a8dd44a5b9eda0612790f Mon Sep 17 00:00:00 2001 From: Dan Lynch Date: Sat, 21 Jun 2025 16:33:46 -0700 Subject: [PATCH] notes --- packages/deparser/src/deparser.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/deparser/src/deparser.ts b/packages/deparser/src/deparser.ts index 5e3ce882..a5ffd22c 100644 --- a/packages/deparser/src/deparser.ts +++ b/packages/deparser/src/deparser.ts @@ -976,6 +976,10 @@ export class Deparser implements DeparserVisitor { const boolContext = { ...context, bool: true }; + // explanation of our syntax/fix below: + // return formatStr.replace('%s', andArgs); // ❌ Interprets $ as special syntax + // return formatStr.replace('%s', () => andArgs); // ✅ Function callback prevents interpretation + switch (boolop) { case 'AND_EXPR': const andArgs = args.map(arg => this.visit(arg, boolContext)).join(' AND ');