Skip to content

Conversation

@iignatevich
Copy link
Collaborator

…lags

@iignatevich iignatevich marked this pull request as ready for review June 7, 2024 15:17
@davidferlay
Copy link
Contributor

  • Before
➜ pl platform:deploy --help 
Deploy: Deploy Ansible resources to target cluster                                        

Usage:
  plasmactl platform:deploy environment tags [flags]

Flags:
      --check               Check: Run the command in check mode
      --debug               Debug: Run the command in debug mode
      --entrypoint string   Image Entrypoint: Overwrite the default ENTRYPOINT of the image
      --exec                Exec command: Overwrite CMD definition of the container
  -h, --help                help for platform:deploy
      --logs                Logs: Store deploy.logs in file
      --no-cache            No cache: Send command to build container without cache
      --password string     SSH Key passphrase: The passphrase to use
      --remove-image        Remove Image: Remove an image after execution of action
      --use-volume-wd       Use volume as a WD: Copy the working directory to a container volume and not bind local paths. Usually used with remote environments.

Global Flags:
      --keyring-passphrase string   Passphrase for keyring encryption/decryption
  -q, --quiet                       disable stdOut
  -v, --verbose count               log verbosity level, use -vvv DEBUG, -vv WARN, -v INFO
  • After
➜ ./plasmactl platform:deploy --help 
Deploy: Deploy Ansible resources to target cluster

Usage:
  plasmactl platform:deploy environment tags [flags]

Flags:
      --check             Check: Run the command in check mode
      --debug             Debug: Run the command in debug mode
  -h, --help              help for platform:deploy
      --logs              Logs: Store deploy.logs in file
      --password string   SSH Key passphrase: The passphrase to use

Global Action Flags:
      --entrypoint string   Image Entrypoint: Overwrite the default ENTRYPOINT of the image
      --exec                Exec command: Overwrite CMD definition of the container
      --no-cache            No cache: Send command to build container without cache
      --remove-image        Remove Image: Remove an image after execution of action
      --use-volume-wd       Use volume as a WD: Copy the working directory to a container volume and not bind local paths. Usually used with remote environments.

Global Flags:
      --keyring-passphrase string   Passphrase for keyring encryption/decryption
  -q, --quiet                       disable stdOut
  -v, --verbose count               log verbosity level, use -vvv DEBUG, -vv WARN, -v INFO

That's definitely a nice improvement!

However, should'nt --help be part of Global Action Flags ?

@iignatevich iignatevich force-pushed the 46-action-helper-mixing-flags-to-all-actions-with-action-specific-flags branch from 9161cf8 to cc25621 Compare June 10, 2024 09:24
@davidferlay davidferlay merged commit 3982f71 into main Jun 10, 2024
@lexbritvin lexbritvin deleted the 46-action-helper-mixing-flags-to-all-actions-with-action-specific-flags branch August 21, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants