Skip to content

Conversation

@iignatevich
Copy link
Collaborator

No description provided.

@iignatevich iignatevich requested a review from lexbritvin April 21, 2025 12:40
@iignatevich iignatevich marked this pull request as draft April 21, 2025 12:40
@iignatevich iignatevich force-pushed the global_options branch 2 times, most recently from 9a6d7c5 to 81232d7 Compare May 14, 2025 12:45
@iignatevich iignatevich force-pushed the global_options branch 2 times, most recently from 40fa002 to 7a63045 Compare May 26, 2025 13:32
@davidferlay
Copy link
Contributor

davidferlay commented May 26, 2025

The only command I found an issue is meta:

➜  ski-platform git:(1552-testing-plasmactl-release-in-ci) plx meta dev tag --keyring-passphrase-file /tmp/kp --local -vvvvv
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x1ab39fd]

goroutine 1 [running]:
github.com/launchrctl/launchr/pkg/action.(*FnRuntime).Execute(0xc001a9a450, {0x2d0d050, 0x4207880}, 0xc00501ae60)
	github.com/launchrctl/launchr@v0.20.3-0.20250526132847-7a63045f0054/pkg/action/runtime.fn.go:35 +0x3d
github.com/launchrctl/launchr/pkg/action.(*Action).Execute(0xc00501ae60, {0x2d0d050, 0x4207880})
	github.com/launchrctl/launchr@v0.20.3-0.20250526132847-7a63045f0054/pkg/action/action.go:347 +0xeb
github.com/skilld-labs/plasmactl-meta.(*Plugin).executeAction(0xc0002eae40, {0x2d0d050, 0x4207880}, {0x25e4863, 0x4}, 0x0, 0xc001a9a420)
	github.com/skilld-labs/plasmactl-meta@v0.16.2/plugin.go:258 +0x15b
github.com/skilld-labs/plasmactl-meta.(*Plugin).meta(0xc0002eae40, {0x2d0d050, 0x4207880}, {0x7fff636c8fc3, 0x3}, {0x7fff636c8fc7, 0x3}, {{0x2cd90f0, 0x9}, 0x0, ...})
	github.com/skilld-labs/plasmactl-meta@v0.16.2/plugin.go:111 +0x3f5
github.com/skilld-labs/plasmactl-meta.(*Plugin).DiscoverActions.func1({0x2d0d050, 0x4207880}, 0x4207880?)
	github.com/skilld-labs/plasmactl-meta@v0.16.2/plugin.go:82 +0x4af
github.com/launchrctl/launchr/pkg/action.(*FnRuntime).Execute(0xc000413170, {0x2d0d050, 0x4207880}, 0xc0000cf860)
	github.com/launchrctl/launchr@v0.20.3-0.20250526132847-7a63045f0054/pkg/action/runtime.fn.go:36 +0x123
github.com/launchrctl/launchr/pkg/action.(*Action).Execute(0xc0000cf860, {0x2d0d050, 0x4207880})
	github.com/launchrctl/launchr@v0.20.3-0.20250526132847-7a63045f0054/pkg/action/action.go:347 +0xeb
github.com/launchrctl/launchr/pkg/action.(*runManagerMap).Run(0xc000297978?, {0x2d0d050, 0x4207880}, 0xc0000cf860)
	github.com/launchrctl/launchr@v0.20.3-0.20250526132847-7a63045f0054/pkg/action/manager.go:378 +0xa7
github.com/launchrctl/launchr/plugins/actionscobra.CobraImpl.func2(0xc000420008?, {0xc00013e6c0?, 0x2?, 0x6?})
	github.com/launchrctl/launchr@v0.20.3-0.20250526132847-7a63045f0054/plugins/actionscobra/cobra.go:65 +0x38
github.com/spf13/cobra.(*Command).execute(0xc000420008, {0xc00013e660, 0x6, 0x6})
	github.com/spf13/cobra@v1.9.1/command.go:1015 +0xaaa
github.com/spf13/cobra.(*Command).ExecuteC(0xc000420608)
	github.com/spf13/cobra@v1.9.1/command.go:1148 +0x46f
github.com/spf13/cobra.(*Command).Execute(0xc0002ea330?)
	github.com/spf13/cobra@v1.9.1/command.go:1071 +0x13
github.com/launchrctl/launchr.(*appImpl).exec(0xc0000f9680)
	github.com/launchrctl/launchr@v0.20.3-0.20250526132847-7a63045f0054/app.go:173 +0x36b
github.com/launchrctl/launchr.(*appImpl).Execute(0xc0000f9680)
	github.com/launchrctl/launchr@v0.20.3-0.20250526132847-7a63045f0054/app.go:194 +0x11d
github.com/launchrctl/launchr.Run(...)
	github.com/launchrctl/launchr@v0.20.3-0.20250526132847-7a63045f0054/app.go:217
github.com/launchrctl/launchr.RunAndExit()
	github.com/launchrctl/launchr@v0.20.3-0.20250526132847-7a63045f0054/app.go:222 +0x1f
main.main()
	plasmactl/main.go:9 +0xf

from Igor
Probably wrong meta branch was used (without updated dependency)

@davidferlay davidferlay marked this pull request as ready for review June 9, 2025 11:53
@davidferlay davidferlay merged commit 8f1ae26 into main Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants