Prepare site for TLS (remove hardcoded protocols) #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: fix trailing spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A site served over HTTPS can't make requests to resources hosted on HTTP for security reasons. This site currently hard-codes the protocol for a number of non-secure resources, i.e., there are
http://links in the page, which means that the page can't render if served over HTTPS.Instead of hard-coding the protocol for links, we can simply specify
href="//instead ofhref="http://orhref="https://. This will create links that use the same protocol as what the site is being served via. So if the site is being served over http, the links will be http. If it's being served over https, the links will be https. Given that most sites out there support both https and http anyways, making the links respect the current page protocol is usually a very safe change. As such, this pull request implements the dynamic protocol links.Also: fix trailing spaces.