Cannot open links embedded in comments on HTC Sense #187

Closed
matthieugrieger opened this Issue Nov 23, 2012 · 13 comments

Comments

Projects
None yet
2 participants

This may not be a problem with all HTC Sense devices, but on Sense 4.1 (Android 4.0.3), it is impossible to click on links that are within a comment. This problem does not occur on AOSP/CyanogenMod/AOKP ROMs.

This bug occurs for me on a T-Mobile HTC Sensation 4G running ViperS 1.4.1. I am also using version 7.3.3 of reddit sync pro.

Here's a crappy video of what I'm talking about:
https://www.youtube.com/watch?v=stlJ9CiPbN4

Hope this helps!

P.S. I saw this on the subreddit quite a while ago, just thought I would post this on here since I didn't see it.

Owner

laurencedawson commented Nov 23, 2012

Thanks for submitting this. Would it be possible to see if this still is a problem on the current beta?

http://www.reddit.com/r/redditsync/comments/13cxaz/version_740_beta/

Owner

laurencedawson commented Nov 23, 2012

This could be the cause:

http://commonsware.com/blog/2012/07/24/linkify-problem-detection-mitigation.html

edit: Definitely looks like HTC have made some strange decisions: http://code.google.com/p/android/issues/detail?id=39682

I still seem to have the same problem on 7.4.0 beta. Is there anything else I can do to help debug this?

Also, I don't think it's possible for a dev to respond any faster than you have!

Owner

laurencedawson commented Nov 23, 2012

Dang. I'll get a small test app up and running tomorrow. Would you be ok to try that out?

And if I don't reply straight away I forget :)

Yeah, for sure! I'll try it out. Take your time!

Thanks! :)

(being a compsci major this stuff is interesting to me anyway)

Owner

laurencedawson commented Nov 23, 2012

Out of interest. Can you long press a link in the new beta?

Compsci major too :)

That doesn't seem to work either, unfortunately.

Owner

laurencedawson commented Nov 29, 2012

Ok so I've opensourced my implementation, hopefully someone on /r/android will be able to help!

http://www.reddit.com/r/Android/comments/140bwy/ive_just_open_sourced_activetextview_a_simple_way/

If you get chance, could you try the sample apk out?

https://github.com/laurencedawson/activetextview/raw/master/sample/bin/Sample.apk

Need to see if the bug exists in that. Thanks :)

Awesome! I'll test it out in a few hours.

Owner

laurencedawson commented Nov 30, 2012

I've just updated the APK, think I might of cracked this. Let me know anyways :)

I finally got around to testing it out. Had to restore a nandroid.

Long pressing works, but it still seems to do nothing when just normally clicking the links. I looked at the post you made on /r/android and it seems like it is working for other people. Maybe it is just an issue with my ROM (http://forum.xda-developers.com/showthread.php?t=1671547)?

I've since switched back to the CM10 ROM I usually use, and reddit sync still works perfectly on that. So I wouldn't lose any sleep over not getting it to work on my device (especially since it seems to work for others). :P

Owner

laurencedawson commented Nov 30, 2012

Cheers for trying it out :)

Owner

laurencedawson commented Nov 7, 2013

I've now added additional click regions for links in comments in the beta build. This should get around the unclickable link issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment