Skip to content
Permalink
Browse files

Electron release v1.0.139

  • Loading branch information...
laurent22 committed Mar 8, 2019
1 parent 18b8365 commit b35cb9a7ab7071f26c3849a31a7ab0e21d529254
Showing with 2 additions and 2 deletions.
  1. +1 −1 ElectronClient/app/package-lock.json
  2. +1 −1 ElectronClient/app/package.json

Some generated files are not rendered by default. Learn more.

@@ -1,6 +1,6 @@
{
"name": "Joplin",
"version": "1.0.138",
"version": "1.0.139",
"description": "Joplin for Desktop",
"main": "main.js",
"scripts": {

6 comments on commit b35cb9a

@tessus

This comment has been minimized.

Copy link
Collaborator

replied Mar 8, 2019

Is Mermaid still missing in this release?

@laurent22

This comment has been minimized.

Copy link
Owner Author

replied Mar 8, 2019

Yes it's gone and for now it's not likely support for it will be restored.

@tessus

This comment has been minimized.

Copy link
Collaborator

replied Mar 8, 2019

Wow, this is not good. I was really happy that I was finally able to use graphs and sequence diagrams. And I'm sure I was not the only one.

What is the reason for removing support again?

@laurent22

This comment has been minimized.

Copy link
Owner Author

replied Mar 9, 2019

I have some doubts about the quality of this lib so I don't want users to start replying on it if later we need to drop it. I'm planning to see if there are any good, more standard, or more widely used alternatives.

@tessus

This comment has been minimized.

Copy link
Collaborator

replied Mar 9, 2019

I have some doubts about the quality of this lib

Really? This seems like a weird opinion to me. This library is successfully used in dozens of projects, one being the nextcloud markdown rendering plugin and Typora is using it as well. It's the de facto standard for rendering flow charts and sequence diagrams.

Please note that the quality of Electron and react-native is by far worse than mermaid.js. While Katex is mostly used by mathematicians, flow charts and sequence diagrams are highly used by computer scientists.

Removing Mermaid made Joplin a lot less attractive for a huge group of users and you might face quite some backlash over this decision. I truly hope you will reconsider.
There were a bunch of feature requests for flow charts and sequence diagrams.

I'm planning to see if there are any good, more standard, or more widely used alternatives.

There aren't any, because mermaid is the de facto standard. Even, if there was an alternative, I doubt people would accept learning yet another notation.

@laurent22

This comment has been minimized.

Copy link
Owner Author

replied Mar 10, 2019

As I wrote above I'm considering options. I hope we can use something better than Mermaid but, if not, we'll see.

Please sign in to comment.
You can’t perform that action at this time.