New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect line breaks when line ends with multiple spaces #1033

Closed
laurent22 opened this Issue Dec 11, 2018 · 7 comments

Comments

Projects
None yet
4 participants
@subi54

This comment has been minimized.

Copy link

subi54 commented Dec 11, 2018

That's a feature isn't it? Moreover, people who have been using the app for a while, with numerous/long notes, will have to go back and edit everything.

@tessus

This comment has been minimized.

Copy link
Collaborator

tessus commented Dec 12, 2018

Does this mean you change the behaviour that

Line1
Line2

renders as Line1Line2? This would mess up a lot of my notes.

@laurent22

This comment has been minimized.

Copy link
Owner

laurent22 commented Dec 12, 2018

Please have a look at the forum link for more info - https://discourse.joplin.cozic.net/t/md-line-break-with-2-spaces/1175/3

@tessus

This comment has been minimized.

Copy link
Collaborator

tessus commented Dec 12, 2018

I've read the forum entries, but you only said that the two spaces and newline are ignored and are considered a bug.
However, according to specification the current behaviour of Line1\nLine2 to be rendered on two lines is also a bug. Therefore I asked the question above.

@subi54

This comment has been minimized.

Copy link

subi54 commented Dec 12, 2018

Exactly what @tessus commented.

Adding two spaces also means a line break so that people coming from other markdown editors feels at home is one thing but removing the current behaviour of the app is detrimental to current users and users coming from say Evernote or somesuch.

@matsest

This comment has been minimized.

Copy link
Contributor

matsest commented Dec 12, 2018

Isn't is possible to adhere to both that two+ spaces + newline renders line break as well as newline renders line break?

That way new users coming from other .md-editors will feel at home and existing notes for users will not render differently (unless they explicitly filled their notes with two spaces+line break to render .. well, nothing -- which is unlikely)

@laurent22

This comment has been minimized.

Copy link
Owner

laurent22 commented Dec 16, 2018

Isn't is possible to adhere to both that two+ spaces + newline renders line break as well as newline renders line break?

Yes actually "anything + newline", should always render as "anything + newline". The current behaviour of not adding a newline when there are two spaces is a bug.

@laurent22 laurent22 closed this in f05929c Dec 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment