Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images not showing in external editor #1099

Closed
deciacco opened this Issue Jan 4, 2019 · 8 comments

Comments

Projects
None yet
4 participants
@deciacco
Copy link

deciacco commented Jan 4, 2019

Operating system

  • Windows

Application

  • Desktop

This is when editing in external editor while "watching" as opposed to an export. Export to Markdown and then opening the .md file works well in the same editor.

joplintyporaimages

@tessus

This comment has been minimized.

Copy link
Collaborator

tessus commented Jan 4, 2019

This is not a bug. Joplin uses its own notation to reference its attachments (resources). These cannot be shown in an external editor.

However, if you export the note to an .md file , the resulting file should show the image correctly.

@deciacco

This comment has been minimized.

Copy link
Author

deciacco commented Jan 5, 2019

thanks for the feedback tessus... I understand. That's too bad tho... I would think being able to see the images in an external editor is important. Perhaps we need to convert this topic to a feature request... why not use the same links used in an exported .md file in the file for the external editor...

@tessus

This comment has been minimized.

Copy link
Collaborator

tessus commented Jan 5, 2019

Perhaps we need to convert this topic to a feature request...

I doubt this will ever happen. That's basically the same thing as asking to change how Joplin works internally.

why not use the same links used in an exported .md file in the file for the external editor...

Well, think about it. The file you edit won't be the same as the source file. After you save it, the file will be broken, because Joplin does not understand the references anymore.

Using an external editor was a workaround for features like block copying and pasting, multiple text select and change, and other awesome features a real editor might have.
Using an external MD editor is the wrong approach. Joplin is a MD editor.

@bogusred

This comment has been minimized.

Copy link

bogusred commented Jan 5, 2019

+1 for this feature request

@deciacco

This comment has been minimized.

Copy link
Author

deciacco commented Jan 7, 2019

Perhaps we need to convert this topic to a feature request...

I doubt this will ever happen. That's basically the same thing as asking to change how Joplin works internally.

I think that is what I would like to request as Joplin should be able to allow for external editing with images showing. The best of both worlds would be where Joplin converts the links on the fly so external editing will work and then convert them back to the internal notation or perhaps change how Joplin works internally.

why not use the same links used in an exported .md file in the file for the external editor...

Well, think about it. The file you edit won't be the same as the source file. After you save it, the file will be broken, because Joplin does not understand the references anymore.

Correct. Joplin would have to convert back to internal notation.

Using an external editor was a workaround for features like block copying and pasting, multiple text select and change, and other awesome features a real editor might have.
Using an external MD editor is the wrong approach. Joplin is a MD editor.

Understand completely. Perhaps this is the way it needs to stay. I still would like to see images when using an external editor and perhaps others would as well.

@laurent22

This comment has been minimized.

Copy link
Owner

laurent22 commented Jan 7, 2019

There's already something to show the images with full paths when exporting to md so maybe it can be added during serialization of the note.

@laurent22 laurent22 closed this in 949dbf4 Jan 20, 2019

@bogusred

This comment has been minimized.

Copy link

bogusred commented Jan 25, 2019

W00t thank you Laurent! Way to go! ♥️

@deciacco

This comment has been minimized.

Copy link
Author

deciacco commented Jan 28, 2019

Thank you so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.