Mobile Rich Text editor: Remaining major tasks

[personalizedrefrigerator]

A Rich Text Editor was added to the mobile app in #12748. This issue tracks the remaining tasks for this editor.

• Mobile Rich Text Editor: Make it possible to edit math and code blocks #12841
• Mobile Rich Text Editor: Render more content in the editor #12842
• Support manual resource download mode: Download resources when clicked by the user.
• Mobile Rich Text Editor: Improve support for HTML notes #12843
• Mobile Rich Text Editor: Make initial search behavior match the Markdown editor #12844
• Support editing drawings.
• Support more toolbar buttons:
  • Swap line down
  • Swap line up
  • Duplicate line
  • Sort selected lines
• Improve the toolbar:
  • Toolbar editor: Indicate whether an action is unsupported in the current editor. Currently, actions are only disabled/greyed out after being added to the toolbar.
  • Tables: Add UI for adding/removing table rows/columns/cells -- Mobile: Resolves #13067: Rich Text Editor: Improve table support #13413.
  • Horizontal lines: Add UI for adding horizontal rules (<hr/>s).
  • Block quotes: Add UI for adding/removing block quote formatting.
  • Text color: Add UI for changing the color of selected text.
  • Mobile: Rich Text Editor: Add UI for creating new code blocks #13058
  • Disable toolbar buttons when their corresponding commands are disabled. For example, the "bold" button should be disabled when inline code is selected.
• Improve saving:
  • Preserve toplevel style blocks on save.
    • This partially works. However, style blocks are minified and certain characters are escaped.
  • Preserve HTML comments on save.
  • Improve save performance for large documents?
  • Fix empty newlines added after all items in lists in rendered Markdown.
• Improve list behavior
  • Improve how toolbar buttons and keyboard shortcuts work with task lists containing other list types.
  • Improve how list toggle behavior works with hard breaks.
  • Mobile: Rich Text Editor: Checklists saved with extra space #13081
  • Android prosemirror editor doesn't react to tab physical key #13356

[mrjo118]

@personalizedrefrigerator possibly related to #12748 , I'm seeing this error in the logs whenever opening a note in edit and then pressing the 3 dots menu, on mobile while the markdown editor is enabled, since upgrading to 3.4.3 on Android:

MarkdownEditor: CodeMirror error error:Unable to find parent element for editor (class name: "CodeMirror"):{}

[personalizedrefrigerator]

MarkdownEditor: CodeMirror error error:Unable to find parent element for editor (class name: "CodeMirror"):{}

Some refactoring was done as a part of the Rich Text Editor pull request. Prior to the refactoring,

• If the parent element for the editor could not be found, a warning was logged within the WebView:

  joplin/packages/app-mobile/components/NoteEditor/NoteEditor.tsx

  Line 407 in ea49907

  console.warn('No parent element for the editor found. This may mean that the editor HTML is still loading.');

After the refactoring,

• The parent element is now specified using a string, as a parameter to a .ts file:
  

  joplin/packages/app-mobile/components/NoteEditor/CodeMirror/CodeMirror.ts

  Line 20 in ea49907

  parentElement: HTMLElement,

• If the parent can't be found, an Error is thrown:
  

  joplin/packages/app-mobile/contentScripts/markdownEditorBundle/contentScript.ts

  Line 19 in 020ba10

  throw new Error(`Unable to find parent element for editor (class name: ${JSON.stringify(parentElementClassName)})`);

The new message in Joplin's logs likely comes from the switch from console.warn to throw new Error, which would be caught and sent to Joplin's logs here.

This comment from before the refactoring states that the editor initialization script could be added to the WebView multiple times:

joplin/packages/app-mobile/components/NoteEditor/NoteEditor.tsx

Lines 385 to 386 in ea49907

	// On Android, injectJavaScript is run twice -- once before the parent element exists.
	// To avoid logging unnecessary errors to the console, skip setup in this case:

Since this error is visible on Android, it's likely that this is still an issue. One possible solution would be to replace the throw new Error with a logger.debug (or logger.info) and a return.

[github-actions]

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.

[github-actions]

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, feel free to create a new issue with up-to-date information.