New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Search in note support #144

Closed
martinpengellyphillips opened this Issue Jan 8, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@martinpengellyphillips

martinpengellyphillips commented Jan 8, 2018

Operating system

  • Windows
  • macOS
  • Linux
  • Android
  • iOS

Application

  • Desktop
  • Mobile
  • Terminal

Would be great for long notes to be able to search within the note itself for specific text, much like how you can "Find in page" in a web browser.

@martinpengellyphillips martinpengellyphillips changed the title from [Request] Search in note support to [Feature Request] Search in note support Jan 8, 2018

@technoboi

This comment has been minimized.

technoboi commented Feb 14, 2018

For me searching within a note is an absolute 'essential'. I successfully converted about 1300 Tomboy Notes to Joplin. They sync well between a Linux desktop and my Android phone. From that viewpoint I am very happy with the way it works. However, many of my notes are very long and all are technical. It is proving too time consuming to search manually within these notes and so, until/if this becomes a feature I'll have to return to Tomboy.

@laurent22

This comment has been minimized.

Owner

laurent22 commented Feb 14, 2018

@technoboi, I'm still not set on what would be a good search feature. Any suggestion on what makes the Tomboy search better?

@technoboi

This comment has been minimized.

technoboi commented Feb 15, 2018

On Tomboy Notes it is possible to make an initial global search. This searches everything in all documents - Headings and message bodies. Then, choose from the list of 'finds' as one does in Joplin. So, up to now Tomboy and Joplin are the same. Once in the chosen note the original global search term is highlighted throughout the document. There is a search box within the note display. In that box is the global search term but that can now be changed and that new search term will change the highlight as appropriate. Starting at the beginning of the document it is possible to use Ctrl-g to progress through all the instances of the search term.
Where Joplin is superior to Tomboy is that it allows file attachments, the sync appears to work well and the Android application isn't sluggish. About seven years ago I made a video on Tomboy. Beyond 6 minutes it is all out of date but the rest is valid. It doesn't specifically show the 'in note' search but you can see the search box. The video might also give you some other ideas.
https://www.youtube.com/watch?v=xCstHOCVExA

@laurent22

This comment has been minimized.

Owner

laurent22 commented Feb 16, 2018

Thanks @technoboi, that makes sense. From that I think the key missing features at the moment are:

  • Highlighting search results

  • Searching within the current note

A way to change the search query once a note has been opened like you mentioned would also be useful.

@laurent22 laurent22 referenced this issue Feb 16, 2018

Closed

Feature request: Boolean search #107

2 of 8 tasks complete

@laurent22 laurent22 added the essential label Mar 10, 2018

@laurent22

This comment has been minimized.

Owner

laurent22 commented Mar 13, 2018

Technical note: use Full Text Search SQLite extension, which will provide ranked results and allow using a limited querying language (AND/OR).

CREATE VIRTUAL TABLE notes_fts USING fts4(content="notes", title, body);

INSERT INTO notes_fts(docid, title, body) SELECT rowid, title, body FROM notes;

SELECT title, offsets(notes_fts) length(offsets(notes_fts)) - length(replace(offsets(notes_fts), ' ', '')) + 1
FROM notes_fts
WHERE notes_fts
MATCH 'test';

@laurent22 laurent22 closed this in 67608e2 Mar 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment