Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Randomly looking at issues, I ended up gathering a list of multiple ones that can be closed, labeled and merged. I prefer to post one single list rather than flooding the site with a bunch of posts.
I hope you find this useful:
Fixed issues, should be closed:
Support requests that should be closed:
Deserve a "tag-ui-issue" label
I suggest you add labels to group related issues, once there's a pattern (when there are 3 or more that aren't duplicates, but closely related):
Deserve a "tag-in-editor" label?
or merge discussions into one?
Ace issues can't be fixed by Joplin. Joplin also depends on brace, and brace seems abandoned, so any editor improvements might not be doable.
Please add an "editor-issue" or "can't fix" to group them. And/or close them and add a "known editor issues" in the documentation or a new issue gathering all of them?
Are there plans to move to a different editor?
There are multiple issues here and in the forum. There should be a pinned forum post or issue, so that you don't get the same request over and over.
These should merge into one discussion or create a "wysiwyg-in-editor" label:
This is definitely useful. Thank you. I meant to something similar a while back, but never got around to it.
Not quite sure how to handle the editor issues. Maybe @laurent22 has an idea.
I wanted to create a bunch of labels a while back. I was also thinking about using nested labels. Something like
@laurent22 I have made a preliminary list to get the ball rolling. The component list is by far not complete and I kindly ask you to come up with additional ones.
Having labels organized this way helps a lot to group issues and plan further development.
Let me know what you think about the following labels:
I suggest we use one color for
I'm not quite sure what to do with
Btw, I have always used
Thanks for looking into this @innocuo. I didn't have time to look into this so far, but your list makes sense. I've sent you a message on the forum, but basically I'm fine with most of your suggestions.
Regarding Brace, I didn't realise it was actually abandoned. One thing I've realised with this project is that it's better to avoid React wrappers like Brace. It's easy enough to do one's own wrapper and then we can update the wrapped library and configure it easily. When I switch to Monaco, that's the approach I'll follow - there'll just be a thin custom wrapper over the Monaco lib. For these issues, I agree we can tag them with something like "brace-on-hold" as they won't be fixed now, but we should revisit them once the editor has been updated.
For WYSIWYG, currently there's no plan to support it. If a good open source wysiwyg JS editor ever exists we can reconsider, but for now every time I review the existing options, I can't find any that would allow the customisations that we would need.
For the tags, I'm not too keen on the namespaces as there are not enough reasons to disambiguate. For example we know what the "linux" tag refers to, so "platform:linux" is not necessary. What I mean is that there's not enough tags and the project is not that big to justify the namespaces. I don't mind if we add some more tags to sort out the issues though.
react-ace depends on brace though. I think that's what they use to add Ace. This issue is about trying to get rid of it. So they might be stuck as well.
Joplin uses an older version of react-ace, maybe upgrading to the latest might resolve some of the issues.
I am interested in WYSIWYG editor.
Can you share your thoughts about the customizations we need and what are the problems with existing options?
as it's possible to use an external editor and joplin won't cover the needs of everybody ; what ever it will be done ; can't we close all the issues from the "Are there plans to move to a different editor?" paragraph and then suggest the users to use external editor ?
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "backlog" and I will leave it open. Thank you for your contributions.