Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF-Export broken: Exporting to PDF causes note content to be cut-off #1815

Closed
evilSwanson opened this issue Aug 18, 2019 · 5 comments

Comments

@evilSwanson
Copy link

commented Aug 18, 2019

Environment

Joplin version: 1.0.165
Platform: Linux
OS specifcs: Kubuntu 18.04.3 LTS x86_64

Steps To Reproduce

  1. Right-click on any note -> Export -> PDF
  2. Open PDF file and see that most of the text is missing

Describe what you expected to happen:
In older versions of Joplin it was possible to export a ordinary markdown note to PDF without any of the content missing in the PDF file. With 1.0.165 only the text which is currently seen in the Joplin markdown-editor is exported and the rest is cut-off. If I scroll down the note only the end of the note is exported to the PDF and the rest is missing. See attached file:
Example_Export.pdf

Logfile

NO log is generated when exporting to PDF!

@tessus

This comment has been minimized.

Copy link
Collaborator

commented Aug 19, 2019

Yes, we think it is an upstream issue and we are trying to figure out what caused the regression.

see also https://discourse.joplinapp.org/t/pdf-export-and-or-print-issues-with-1-0-165/3197?u=tessus

@tessus

This comment has been minimized.

Copy link
Collaborator

commented Aug 19, 2019

According to Caleb's git bisect session, the culprit is 30d0dfb.

By removing the following line, the problem is fixed.

document.getElementById('content').style.height = window.innerHeight + 'px';

@laurent22 do you have any idea why this line screws up PDF export and printing? why was it added in the first place?

@laurent22

This comment has been minimized.

Copy link
Owner

commented Aug 19, 2019

Not sure yet but will check.

@tessus

This comment has been minimized.

Copy link
Collaborator

commented Aug 19, 2019

@laurent22 thx. maybe off-topic, but every time I export to PDF (when using a dark theme), the entire UI reverts to a light time for a flash (I guess maybe 1-2s) and then it goes back to the dark theme. Is there any chance we can avoid this?

@tessus

This comment has been minimized.

Copy link
Collaborator

commented Aug 22, 2019

@laurent22 Ok, found something out: removing the line breaks something else. The preview pane does not scroll and is not scrollable anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.