Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Resources menu item #2530

Merged
merged 2 commits into from Feb 21, 2020
Merged

fix Resources menu item #2530

merged 2 commits into from Feb 21, 2020

Conversation

tessus
Copy link
Collaborator

@tessus tessus commented Feb 20, 2020

On macOS the menu item Resources never showed up under Tools.

follow-up to #2189

@tessus tessus added bug It's a bug desktop All desktop platforms PR-tested labels Feb 20, 2020
@@ -384,6 +384,7 @@ class Application extends BaseApplication {
const importItems = [];
const exportItems = [];
const toolsItemsFirst = [];
var toolsItems = [];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let please. Spacing is not consistent with the rest of the code base but if eslint allow it, why not.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the spaces to align it with the other vars. Old habit. I'll revert it, since the assignments are not aligned either.

Not sure why I used var. I'll fix this.

Sorry, I'm still struggling a bit with the new build system. I haven't found my new workflow yet.

@laurent22
Copy link
Owner

Once the minor issue is fixed and the conflicts sorted please go ahead and merge. Note that I got rid of the app directory in the recent update, so you'll need to move your file one level down.

On macOS the menu item `Resources` never showed up under `Tools`.
@tessus tessus merged commit ce40813 into laurent22:master Feb 21, 2020
@tessus tessus deleted the fix/resource-menu branch March 12, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug It's a bug desktop All desktop platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants