Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop: Header Bar title disappears on switching themes #2615

Closed
rabeehrz opened this issue Feb 29, 2020 · 2 comments · Fixed by #2619
Closed

Desktop: Header Bar title disappears on switching themes #2615

rabeehrz opened this issue Feb 29, 2020 · 2 comments · Fixed by #2619
Labels
bug It's a bug

Comments

@rabeehrz
Copy link
Contributor

rabeehrz commented Feb 29, 2020 •
edited

While switching themes, the title for menu bar items ( Toggle Sidebar, New Notebook etc.)
The titles come back when I restart the App.

bugc9d94c3b9de67ad0.gif

Steps to reproduce

  1. Open Joplin
  2. Go to Appearance and change theme
  3. Go back and see the bug

Environment

Joplin version: Joplin 1.0.185 (dev, darwin)
Platform: Desktop
OS specifics: macOS

Describe what you expected to happen

The header titles should be retained.
@rabeehrz rabeehrz added the bug It's a bug label Feb 29, 2020
@rabeehrz
Copy link
Contributor Author

I would like to work on this issue if this is a bug.

@anjulalk anjulalk mentioned this issue Feb 29, 2020
Merged
@tessus
Copy link
Collaborator

tessus commented Feb 29, 2020

As a matter of fact this also happens in other situations. I haven't been able to reproduce it, because it only happens intermittently. I guess the PR might fix those issues as well.

laurent22 pushed a commit that referenced this issue Mar 1, 2020
Desktop: Fixes #2615: Fix issue with disappearing button labels in to…
a28b790 
…olbar (#2619)

* Fix undefined showButtonLabels

* Add showButtonLabels to the state; Removed conditional statement checking if state is undefined
@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug It's a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Desktop: Fix undefined showButtonLabels anjulalk/joplin
2 participants
@tessus @rabeehrz