Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supressing checkboxes #2646

Closed
sciurius opened this issue Mar 3, 2020 · 7 comments
Closed

Supressing checkboxes #2646

sciurius opened this issue Mar 3, 2020 · 7 comments
Labels
bug It's a bug

Comments

@sciurius
Copy link

sciurius commented Mar 3, 2020

Assume we have the following content somewhere in a note:

<style>
.md-checkbox input[type="checkbox"]:not(:checked),
.md-checkbox input[type="checkbox"]:not(:checked)+label {
	display:none;
}
</style>
## Topic
## Topic
- [ ] Seitan
- [ ] Blanke bonen
- [ ] Berglinzen
- [ ] Couscous
- [ ] Citroensap
- [ ] Limoensap
## Topic
- [ ] Seitan
- [ ] Blanke bonen
- [x] Berglinzen
- [x] Couscous
- [ ] Citroensap
- [ ] Limoensap
## Topic
## Topic

The Android client (1.0.312) suppresses all the unchecked checkbox lines.
Screenshot_20200303-135210_Joplin

The Linux desktop (1.0.187) does not show the unchecked checkbox lines, but some additional vertical space is added.
scrot20200303134919

AFAIK this is a regression since I'm pretty sure the Linux desktop used to behave the same as the Android cient.

@sciurius sciurius added the bug It's a bug label Mar 3, 2020
@laurent22
Copy link
Owner

The HTML structure might have changed, so you might need to update your CSS. There's unfortunately not guarantee that the HTML will remain stable from one version to the next. In general userstyle.css is "use at your own risk" (or better, don't use it, but that's up to the user).

@laurent22
Copy link
Owner

Sorry I've spoken too quickly and there was indeed a bug with HTML rendering in the latest version. Normally this commit should fix it cb2df32 and it will be part of the next release.

@sciurius
Copy link
Author

sciurius commented Mar 4, 2020

I tried git 880134c (that includes this) but the rendering is still affected.

@laurent22
Copy link
Owner

laurent22 commented Mar 4, 2020

Could you check the HTML with the dev tools? Where do the new lines come from?

@laurent22
Copy link
Owner

These blank spaces seem to be a different issue. The md-checkbox class has a margin, which you would need to remove with your CSS.

image

Don't think that was changed recently, but even then it doesn't seem to be a bug.

@sciurius
Copy link
Author

sciurius commented Mar 4, 2020

Rendering was ok up to previous release (1.0.179, January 24) so it is a regression due to a recent change.

@sciurius
Copy link
Author

sciurius commented Mar 6, 2020

In 1.0.190, hiding the checkboxes seems to not work at all anymore.
I'd suggest re-opening this issue.

@lock lock bot locked and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug It's a bug
Projects
None yet
Development

No branches or pull requests

2 participants