Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Spell check #275

Open
alexdevero opened this issue Mar 7, 2018 · 23 comments

Comments

@alexdevero
Copy link
Contributor

commented Mar 7, 2018

Since Joplin is note taking app having some option to check the text for spelling errors could be a nice feature.

Operating system

  • Windows
  • macOS
  • Linux
  • Android
  • iOS

Application

  • Desktop
  • Mobile
  • Terminal

@alexdevero alexdevero changed the title Feature Request: Spellcheck Feature Request: Spell check Mar 7, 2018

@nhoening

This comment has been minimized.

Copy link

commented Mar 20, 2018

+1

@diogogomes

This comment has been minimized.

Copy link

commented Jul 26, 2018

Consider to add multiple language checker. Thanks

@xelcho

This comment has been minimized.

Copy link

commented Sep 18, 2018

+1

@alexdevero

This comment has been minimized.

Copy link
Contributor Author

commented Sep 19, 2018

The electron-spell-check package might be useful.

@noamgu

This comment has been minimized.

Copy link

commented Sep 29, 2018

+1

@kelseyurgo

This comment has been minimized.

Copy link

commented Nov 27, 2018

+1

1 similar comment
@marc0der

This comment has been minimized.

Copy link

commented Dec 21, 2018

+1

@diogogomes

This comment has been minimized.

Copy link

commented Dec 21, 2018

Please, use the 👍 icon instead of write +1 to not overflow the mail subscribers of this issue.

Thank you

@laurent22

This comment has been minimized.

Copy link
Owner

commented Dec 21, 2018

Another thing is that +1s are ignored during the development process. There could be a thousand of them and still the issue would be ignored. However thumbs up are used to determine what issues are the most popular so that's what you need to do to push the issue forward.

@marc0der

This comment has been minimized.

Copy link

commented Feb 2, 2019

@diogogomes @laurent22 Totally agree and point taken. The issue does remain that you have 27 thumbs up for this issue at this point with no action taken or feedback given since the 7th March 2018 (almost a year ago).

I'm sure many folks (including myself) would love to help get this feature built but we would probably need some guidance regarding how to do this.

@blueorignal

This comment has been minimized.

Copy link

commented Feb 15, 2019

@laurent22, following on from @marc0der, would it be helpful if the community provided you with dictionaries for different languages? Otherwise, I too would like to assist implement the spell check functionality, but would require inputs as to what you need to help make this happen. Irrespective about your decision re: spell checking, I wanted to say a big thank you for your work on Joplin. Joplin has become one of my most critical programs and substantially improved my general workflow.

@laurent22

This comment has been minimized.

Copy link
Owner

commented Feb 15, 2019

If we were to implement this we would use the built-in system dictionaries, if at all possible.

@blueorignal

This comment has been minimized.

Copy link

commented Feb 18, 2019

If we were to implement this we would use the built-in system dictionaries, if at all possible.

Thank you. That makes perfect sense.

@laurent22

This comment has been minimized.

Copy link
Owner

commented Mar 3, 2019

Blocked by #1128 because Ace Editor doesn't support spell checking.

@blueorignal

This comment has been minimized.

Copy link

commented Mar 4, 2019

Thank you for investigating. Much appreciated.

@CollinChaffin

This comment has been minimized.

Copy link

commented Mar 9, 2019

As much as I've been ranting about how great Joplin is and quickly has become my go-to note app overtaking onenote & evernote, it's funny that spell-check is like air you just assume it's there and sometimes you forget about it as much as I need spell-check it wasn't until I hit a really tough doc and knew I needed that magic "right-click to fix" that we've all becomed so accustomed to, and found unlike any other recent app - it was not there! :(

I chucked as I typed this comment and sure enough needed to right-click-to-fix twice. Point is this is a pretty basic feature nowadays and it looks like there is even a pre-built electron spellcheck library that could be used, so can I as as someone who is not an electron app dev but does other dev work as to what the major hurdles are on getting this implemented? Reading above I don't see many specifics on why is CANNOT be done and hasn't been in a year, so is it just a matter of resources or ?

@laurent22

This comment has been minimized.

Copy link
Owner

commented Mar 10, 2019

The editor we use doesn't support the built in Electron spell checking so something custom would need to be built.

@dddjjjbbb

This comment has been minimized.

Copy link

commented Apr 2, 2019

Just a note, in case it's of any interest to any of you in the thread. Given the Electron package doesn't seem to be a viable option and this feature isn't part of the current road map, you can open any note in question in an external editor via the button to the left of the tag icon (in my case, CotEditor) and run a spell check there. It's the best solution I found for the time being. Hope that helps.

@blueorignal

This comment has been minimized.

Copy link

commented Apr 3, 2019

@dddjjjbbb thank you. That's a simple, workable solution.

@flemay

This comment has been minimized.

Copy link

commented Apr 4, 2019

@CollinChaffin I, too, thought spellcheck would come by default and having the workflow: write your document in Joplin -> copy into another app to fix the mistakes -> copy back to Joplin is not ideal.

@dddjjjbbb's suggestion works although I am not sure if the file stays on disk indefinitely (i.e: ~/.config/joplin-desktop/tmp/eb94e8d92e23f72fa8fe153b9fa1f72c.md)

UPDATE: Actually the file gets deleted after you stop watching it from Joplin. :)

@kign

This comment has been minimized.

Copy link

commented Jul 29, 2019

Indeed, like many others pointed out, spell check is a must-have. There are multiple other problems I encountered in a few days I was trying to use it, but spellcheck is a deal breaker for me.

@deljones

This comment has been minimized.

Copy link

commented Aug 6, 2019

I love Joplin, use it for everything and yes the absence of a spell checker is a shame so what I do , as a Windows user, is to use NotePad++ and then in Joplin point to an external. I have installed the spell check plugin for NotePad++ and asked the plug in to use Windows Native spell checking. It works perfectly for me. My spelling is atrocious at best. Click save in NotePad++ and Joplin picks it up. Nice, not ideal but as a work around I find it useful.

Just my thoughts

@vb0

This comment has been minimized.

Copy link

commented Aug 16, 2019

Funny thing is that with Joplin I've been trying to move away from NotePad++ after I've got tired from having my sessions saved FINE every day for weeks until BANG at some point it'll forget everything (usually after an update or possibly after a hasty shutdown with "this program is preventing windows from shutting down would you like to close it"). And then I had to hunt for a bunch of files opened from I don't even remember where and some drafts I've never saved. But who knows, maybe as just a spell-checking editor npp would work well after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.