Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save passwords to system keychain #2773

Open
laurent22 opened this issue Mar 16, 2020 · 2 comments · May be fixed by #2861
Open

Save passwords to system keychain #2773

laurent22 opened this issue Mar 16, 2020 · 2 comments · May be fixed by #2861

Comments

@laurent22
Copy link
Owner

@laurent22 laurent22 commented Mar 16, 2020

The current version of Joplin saves the sync passwords to the database. Normally, this is secure as long as the system itself is secure.

However for improved security, the passwords should be saved to the system keychain. This can be done in a cross platform way using https://github.com/atom/node-keytar

The difficulty will be too read and write these passwords in a transparent way from the Setting class.

@laurent22 laurent22 changed the title Save passwords in keychain Save passwords to system keychain Mar 16, 2020
@Rishgod

This comment has been minimized.

Copy link
Contributor

@Rishgod Rishgod commented Mar 16, 2020

Seems like a nice improvement!

@ishriom53tyagi

This comment has been minimized.

Copy link

@ishriom53tyagi ishriom53tyagi commented Mar 17, 2020

i would like to work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.