Mobile: Resolves #7687: Use .remove instead of removeEventListener #7688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React Native 0.69 [deprecated removeEventListener](https://reactnative.dev/docs/0.69/dimensions#removeeventlistener) (perhaps it was deprecated before then). It seems to have been removed in React Native 0.70. This commit replaces removeEventListener with EmitterSubscription::remove.
personalizedrefrigerator
changed the title
laurent22
reviewed
Jan 29, 2023
packages/app-mobile/ios/Podfile.lock
Outdated
| @@ -693,7 +693,7 @@ SPEC CHECKSUMS: | |||
| Flipper-RSocket: d9d9ade67cbecf6ac10730304bf5607266dd2541 | |||
| FlipperKit: cbdee19bdd4e7f05472a66ce290f1b729ba3cb86 | |||
| fmt: ff9d55029c625d3757ed641535fd4a75fedc7ce9 | |||
| glog: 04b94705f318337d7ead9e6d17c019bd9b1f6b1b | |||
| glog: 5337263514dd6f09803962437687240c5dc39aa4 | |||
There was a problem hiding this comment.
Please revert the changes on this file. On my laptop too it gets randomly updated and it's not clear why, but we shouldn't commit this
There was a problem hiding this comment.
This should be fixed!
packages/app-mobile/root.tsx
Outdated
| Linking.removeEventListener('url', this.handleOpenURL_); | ||
| if (this.appStateChangeListener_) { | ||
| this.appStateChangeListener_.remove(); | ||
| this.urlOpenListener = null; |
There was a problem hiding this comment.
Should be appStateChangeListener_
There was a problem hiding this comment.
Thank you for catching this! It should be fixed.
|
Thanks for the fix! |
|
By the way, the commit messages is what ends up in the changelog, so it should be more user-facing. So instead of something technical like "Use .remove instead of removeEventListener", it would be better something like "Fix startup error". |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
root.tsx,AppComponent.componentWillUnmountusesremoveEventListener, which has been deprecated and seems to not be present in React Native 0.70. This was causing an error when reloading the app.componentWillUnmountinAppComponent#7687Testing plan
yarn startyarn watchin the mobile app directoryNote: I attempted to create an automated test that reloads the root component, but
jestwas having trouble withimportstatements in some.jsfiles imported/required byroot.tsx.