New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF export - export title too #890

Closed
laurent22 opened this Issue Oct 15, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@moltenjs

This comment has been minimized.

Contributor

moltenjs commented Oct 31, 2018

I think I'll send a pull request.

moltenjs pushed a commit to moltenjs/joplin that referenced this issue Oct 31, 2018

Ben Fisher
Show note title in pdf export (laurent22#890)
An example of a possible approach, to temporarily change the html in the webview to show the note title. Works, but there may be a more elegant fix.

laurent22 added a commit that referenced this issue Nov 7, 2018

Show note title in pdf export (#890) (#937)
* Show note title in pdf export (#890)

An example of a possible approach, to temporarily change the html in the webview to show the note title. Works, but there may be a more elegant fix.

* Show title in pdf export

Revising based on feedback
Also, a couple changes to tests so that they pass in Windows.

@laurent22 laurent22 closed this Dec 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment