Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Preserve #t=a,b and #page=n hashes when rendering PDF and audio/video viewers #9745

Open
personalizedrefrigerator opened this issue Jan 18, 2024 · 0 comments
Labels
backlog We'll get to it... eventually... enhancement Feature requests and code enhancements renderer About the note renderer

Comments

@personalizedrefrigerator
Copy link
Collaborator

personalizedrefrigerator commented Jan 18, 2024

Summary

Joplin should preserve #t=2,4- and #page=4-style hashes at the end of resource links when rendering PDF and audio/video viewers.

Details

Currently, markup similar to the following produces HTML without the hash:

[A video](:/fccec872867b45959eb5fd58f1d44a82#t=1,2)

Currently, this produces HTML similar to the following:

<p class="maps-to-line" source-line="27" source-line-end="28"><a data-from-md="" data-resource-id="fccec872867b45959eb5fd58f1d44a82" title="spellcheck-demo.mp4" type="video/mp4" href="#" onclick="ipcProxySendToHost(&quot;joplin://fccec872867b45959eb5fd58f1d44a82#t=1,2&quot;, { resourceId: &quot;fccec872867b45959eb5fd58f1d44a82&quot; }); return false;"><span class="resource-icon fa-file-video"></span>A video</a>
	<video class="media-player media-video" controls="">
		<source src="/home/primary/snap/joplin-desktop/56/.config/joplin-desktop/resources/fccec872867b45959eb5fd58f1d44a82.mp4" type="video/mp4">
	</video>
</p>

Preserving the #t=1,2 would allow users to specify the playback range.

Similarly, it should be possible to show a specific PDF page using a #page=123-style hash.

@personalizedrefrigerator personalizedrefrigerator added bug It's a bug enhancement Feature requests and code enhancements backlog We'll get to it... eventually... renderer About the note renderer and removed bug It's a bug labels Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We'll get to it... eventually... enhancement Feature requests and code enhancements renderer About the note renderer
Projects
None yet
Development

No branches or pull requests

1 participant