-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop: Resolves #9998: Fixed text wrapping in Spellcheck button #10005
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Now that I see the screenshot... Is it possible to instead cut the text with an ellipsis? |
|
Will try to do so and get back to you. |
|
I tried the following css but the text won't truncate without setting a specific value to the width, which then wont show the full text even when you expand it. Will try it out some more, any ideas? Edit: |
|
I had to wrap text inside the ToolbarButtons with a span, otherwise it wouldn’t truncate with ellipsis, it just truncated from both sides. Also apologies if I do this wrong but @PackElend label me please (Do I ask for this label after creating future PRs as well?). |
yes, otherwise we cannot track your work |
| @@ -43,7 +43,10 @@ export default function ToolbarButton(props: Props) { | |||
| if (!isEnabled) classes.push('disabled'); | |||
|
|
|||
| const onClick = getProp(props, 'onClick'); | |||
|
|
|||
| const style: any = { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't use "any". React.CSSProperties is the correct type here I believe

Description
Fixed #9998 using one liner.
Screenshots
Before:


After: