-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop: Resolves #9553: Added enter key support to navigate search results #10013
Conversation
Signed-off-by: Najam Ul Saqib <najam.saqib@constellationdealer.com>
Signed-off-by: Najam Ul Saqib <najam.saqib@constellationdealer.com>
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
We have heard of this issue before but never been able to replicate it or fix it. Would you mind trying to commit again on your Windows machine and see what happens - is there any error or warning? Could you provide a screenshot if there's something? |
|
Also all the commits need to be under the same username for the CLA to be valid. So you might want to squash all the commits under the CLA name |
|
recheck |
|
Thanks for checking. I'm not sure why
|
|
Oh I see it now, that script should be executed from the root of the repository, so in your case from |
|
Now the problem is that I'm not sure what should be implemented here. Feel free to participate in the discussion at #9553 to figure this out |
|
Closing for now. We need to define what we want to implement (if anything) |


Fixes #9553
@PackElend label me please, apologies pre-commit hooks didnt execute on previous PR, it was some issue with my Windows machine, now creating this PR with macbook and pre-commits hook executed successfully
Introduction URL: https://discourse.joplinapp.org/t/introducing-najam/36216
With 💚 from Tecvity