Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/mobile plugin support/just panels and dialogs #10121

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This pull request does two things:

  1. Adds support for plugin dialogs, panels, and more commands
  2. Adds support for the Outline plugin -- Adds polyfills, mocks, and fixes a supportsCommand bug.

Screenshots

screenshot: "Show plugin panels" menu item highlighted

Notes

I'm not sure how much I like the current way to show and hide plugin panels. The note actions menu is getting very full.

Here are a few other possible GUIs:

1. Show the plugin panels in the "properties" sidebar

screenshot: Sidebar on right side of screen expanded, includes created and updated time, and view on map. Just below view on map is a large blue rectangle.

2. Show the toggle button in the main toolbar

This has the benefit of allowing plugins to be shown even when a note is not open. I also have a draft implementation of this on a separate branch (though it needs accessibility changes).

screenshot: main toolbar toggle button shown, clicking on it (indicated by an arrow), shows a dialog that lists open plugin panels

Testing

To test this pull request,

  1. Install the "Outline" and "automatic backlinks" plugins (and also possibly "Link Graph UI")
  2. Enable the "automatic backlinks" panel in its settings
  3. Open a note
  4. Show the plugin panels
  5. Switch between them
  6. Verify that backlinks and headings are shown in the outline and backlinks panels, respectively.

This has been tested manually on an Android 12 emulator.

@laurent22
Copy link
Owner

I agree that having all these options in the menu is not ideal, especially since the user might want to frequently access certain panels. Do we have examples of what other apps are doing for these kind of extra panels?

Otherwise your option 2 seems better but I'm not completely sure about it as it doesn't feel right to add a button just for this in this header bar (or maybe it's fine I'm just not sure).

@laurent22
Copy link
Owner

In the meantime I'm merging the pull request since the UX improvement could be in a different PR, thanks for implementing this!

@laurent22 laurent22 merged commit b3ec92a into laurent22:dev Mar 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants