New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate editor font size option #1027

Merged
merged 1 commit into from Dec 7, 2018

Conversation

Projects
None yet
2 participants
@CalebJohn
Copy link
Contributor

CalebJohn commented Dec 4, 2018

Based off my own use and this thread on the discourse I thought it would useful to set the editor font size separate of the style.zoom. In my own use case all the graphic elements are a decent size, but the editor font is a touch small.
Basically this pull adds the new setting style.editor.fontSize

Also included in this pull is a fix for font sizing line height. Previously the line height didn't change with the font size causing lines to overlap
image

But now the line height is correctly set based on the font size.
screenshot from 2018-12-03 17-44-32

@@ -101,6 +101,7 @@ class Setting extends BaseModel {
'encryption.activeMasterKeyId': { value: '', type: Setting.TYPE_STRING, public: false },
'encryption.passwordCache': { value: {}, type: Setting.TYPE_OBJECT, public: false, secure: true },
'style.zoom': {value: 100, type: Setting.TYPE_INT, public: true, appTypes: ['desktop'], label: () => _('Global zoom percentage'), minimum: 50, maximum: 500, step: 10},
'style.editor.fontSize': {value: 12, type: Setting.TYPE_INT, public: true, appTypes: ['desktop'], label: () => _('Editor font size'), minimum: 4, maximum: 50, step: 10},

This comment has been minimized.

@laurent22

laurent22 Dec 5, 2018

Owner

That should probably be step: 1 (10 make too big a difference)

@laurent22

This comment has been minimized.

Copy link
Owner

laurent22 commented Dec 5, 2018

Looks good except for one comment I've added.

@CalebJohn CalebJohn force-pushed the CalebJohn:editor-font-size branch from 590c05e to e6b31a3 Dec 6, 2018

@CalebJohn

This comment has been minimized.

Copy link
Contributor

CalebJohn commented Dec 6, 2018

My bad, that was a silly mistake. Thanks for the review.

@laurent22

This comment has been minimized.

Copy link
Owner

laurent22 commented Dec 7, 2018

Perfect, thanks @CalebJohn!

@laurent22 laurent22 merged commit 3b14cfc into laurent22:master Dec 7, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@CalebJohn CalebJohn deleted the CalebJohn:editor-font-size branch Jan 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment