Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Support copying app information #10336

Merged

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Apr 19, 2024

Summary

This extracts changes from #10319 into a separate pull request.

Specifically, it:

  • Makes the mobile "more information" screen use the same versionInfo logic as is used on desktop.
    • This includes a list of the user's installed plugins.
  • Adds a copy button to that screen.

Note: This pull request moves all copyable version information into the same text block. Previously, each line was in a separate component with a border.

Screenshots

App info shown in the more information screen with a copy version info button below it, dark mode app info shown in light mode, also with a copy version info button

Testing plan

  1. Open settings
  2. Open "More information"
  3. Click "COPY VERSION INFO"
  4. Verify that version information was copied — paste the version information into a note.

This has been tested successfully on Android 7.

@laurent22
Copy link
Owner

I feel it looks a bit messy now without the lines between each item?

@laurent22 laurent22 merged commit 34b2654 into laurent22:dev Apr 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants