Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All: Add new encryption methods based on native crypto libraries #10696
All: Add new encryption methods based on native crypto libraries #10696
Changes from 1 commit
71f020417aa0fda2be9f117badd580a764b4c8c2f38387c960276041832e589373ecacd3bd657e4eb58cf2ed4730182cce48b54ec70db35452f82447b7595f26faf2663f6ce9295ef6f9d39eb7bfc3ecb73b4c5abf0f12661dd12d1536a048b20d1204dfc8bb912dca2adf43895281e7d780b09cbf2563d7a3b9c885a4b6b96bd0db99f9fc7026dc2bca6e4dd9d8eaebb69f50bc9605e91f9c9bb329c0cd0140da41e79186087f7772366e2dfefff72fc951d1f9525d10c185fd56dfc0ab22f04701c313b63707158aec1dcb9b0771a2c3d22855ec77dc4eec9a7b3102b42bbf8cfd6dd6de1015bf0d5128def1be115b5028fcc8eeedd2a90a786478d8f243ae78cc105934ccb9e22379002f7de98acc2aFile filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the use of a class makes sense here. Is it just to group these functions together? In that case a file
crypto.tsmight be preferable with plain functions inside.Also the fact that it is "native" doesn't really matter, so it should not appear in the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove it.
I guess this is the grouped plain functions, right? If so I can rewrite these functions in that way.
https://github.com/laurent22/joplin/blob/v3.0.1/packages/lib/services/e2ee/RSA.node.ts#L11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the
Nativein the name and renamed these modules toCryptoin commit a2be9f1.However, I just noticed that the name
Cryptohas been used in the Web Crypto API. I guess it's better to use a different name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the class definition in commit 17aa0fd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As @tessus suggested, I've replaced the name to
Krypto