Desktop: Seamless-Updates - creation of auto updater service #10772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurent22
reviewed
Jul 22, 2024
| @@ -0,0 +1,120 @@ | |||
| import { app, BrowserWindow } from 'electron'; | |||
| import { autoUpdater, UpdateInfo } from 'electron-updater'; | |||
| import log from 'electron-log'; | |||
There was a problem hiding this comment.
If possible please use our Logger class, so that log statements are sent to the expected file. Have a look how it's done in other files, but the pattern basically is const logger = Logger.create('AutoUpdaterService')
| import { autoUpdater, UpdateInfo } from 'electron-updater'; | ||
| import log from 'electron-log'; | ||
| import path = require('path'); | ||
| import { setInterval } from 'timers'; |
There was a problem hiding this comment.
Please use shim.setInterval if possible - the reason is that it's going to use a more reliable timer and it's also easier to track all timers in the app.
Comment on lines
17
to
18
| const DEFAULT_UPDATE_INTERVAL = 12 * 60 * 60 * 1000; | ||
| const INITIAL_UPDATE_STARTUP = 5 * 1000; |
There was a problem hiding this comment.
We use camelCase for constants: https://joplinapp.org/help/dev/coding_style#use-camelcase-for-constants-in-new-code
|
Thanks Alice, let's merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the Auto Updater Service. The service will only log the update events and will not download or install the updates (for now). This way, this PR's code can monitor the availability of updates through the logs without triggering any update process.
Events that are logged: