Desktop: Seamless-Updates - creation of update notification #10791
Conversation
|
Would you mind providing a screenshot of the notification? |
|
|
||
| const messageHtml = ` | ||
| <div class="update-notification" style="color: ${theme.color2};"> | ||
| A new update (${info.version}) is available. <a href="#" onclick="openChangelogLink()" style="color: ${theme.color2};">See Changelog</a> |
There was a problem hiding this comment.
Please localise all user-facing text. Here for example if would be _('A new update (%s) is available', info.version)
|
Sure! This is how it looks like: |
| ${_('A new update (%s) is available', info.version)} <a href="#" onclick="openChangelogLink()" style="color: ${theme.color2};">${_('See Changelog')}</a> | ||
| <div style="display: flex; gap: 10px; margin-top: 8px;"> | ||
| <button onclick="document.dispatchEvent(new CustomEvent('${UpdateNotificationEvents.ApplyUpdate}'))" class="notyf__button notyf__button--confirm" style="color: ${theme.color2};">${_('Restart now')}</button> | ||
| <button onclick="document.dispatchEvent(new CustomEvent('${UpdateNotificationEvents.Dismiss}'))" class="notyf__button notyf__button--dismiss" style="color: ${theme.color2};">${_('Update Later')}</button> |
There was a problem hiding this comment.
Please make sure you escape the translated strings (otherwise it'd be possible for a translator to inject html in here). See here for more information: https://joplinapp.org/help/dev/coding_style/#escape-variables
|
|
||
| const messageHtml = ` | ||
| <div class="update-notification" style="color: ${theme.color2};"> | ||
| ${_('A new update (%s) is available', info.version)} <a href="#" onclick="openChangelogLink()" style="color: ${theme.color2};">${_('See Changelog')}</a> |
There was a problem hiding this comment.
"See Changelog" => "See changelog" (we don't use titlecase in general)
| ${_('A new update (%s) is available', info.version)} <a href="#" onclick="openChangelogLink()" style="color: ${theme.color2};">${_('See Changelog')}</a> | ||
| <div style="display: flex; gap: 10px; margin-top: 8px;"> | ||
| <button onclick="document.dispatchEvent(new CustomEvent('${UpdateNotificationEvents.ApplyUpdate}'))" class="notyf__button notyf__button--confirm" style="color: ${theme.color2};">${_('Restart now')}</button> | ||
| <button onclick="document.dispatchEvent(new CustomEvent('${UpdateNotificationEvents.Dismiss}'))" class="notyf__button notyf__button--dismiss" style="color: ${theme.color2};">${_('Update Later')}</button> |
| Dismiss = 'dismiss-update-notification', | ||
| } | ||
|
|
||
| const changelogLink = 'https://joplinapp.org/help/about/changelog/desktop/'; |
There was a problem hiding this comment.
For the changelog it's a bit tricky because it is updated with a delay, so it may not have the information by the time the user gets the notification. So to be sure let's link instead to https://github.com/laurent22/joplin/releases
This commit contains: